Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1950303002: MD Extensions: Fix sidebar icons by including iron-icons.html (Closed)

Created:
4 years, 7 months ago by michaelpg
Modified:
4 years, 7 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Extensions: Fix sidebar icons by including iron-icons.html Extensions relied on cr_search_field including iron-icons for icons that extensions uses. Instead Extensions should import iron-icons directly. BUG=609424 R=rdevlin.cronin@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/md_extensions/icons.html View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
michaelpg
PTAL, fixes the regression at https://bugs.chromium.org/p/chromium/issues/detail?id=609424
4 years, 7 months ago (2016-05-05 15:33:20 UTC) #3
Devlin
I had a fix for this last night, and just didn't send it out. Teach ...
4 years, 7 months ago (2016-05-05 15:55:01 UTC) #4
michaelpg
https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md_extensions/icons.html File chrome/browser/resources/md_extensions/icons.html (right): https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md_extensions/icons.html#newcode2 chrome/browser/resources/md_extensions/icons.html:2: <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html"> On 2016/05/05 15:55:01, Devlin wrote: > ...
4 years, 7 months ago (2016-05-05 16:10:15 UTC) #5
Devlin
4 years, 7 months ago (2016-05-05 17:00:05 UTC) #6
On 2016/05/05 16:10:15, michaelpg wrote:
> Feel free to push your fix instead.

Okay, will take this one.

Powered by Google App Engine
This is Rietveld 408576698