MD Extensions: Fix sidebar icons by including iron-icons.html

MD Extensions: Fix sidebar icons by including iron-icons.html

Extensions relied on cr_search_field including iron-icons for icons that extensions uses. Instead Extensions should import iron-icons directly.

BUG=609424
R=rdevlin.cronin@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

[michaelpg, 2016-05-05 15:31:24]

Description was changed from

==========
MD Extensions: Fix sidebar icons by including iron-icons.html

BUG=609424
R=rdevlin.cronin@chromium.org
==========

to

==========
MD Extensions: Fix sidebar icons by including iron-icons.html

BUG=609424
R=rdevlin.cronin@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-05 15:33:04]

Description was changed from

==========
MD Extensions: Fix sidebar icons by including iron-icons.html

BUG=609424
R=rdevlin.cronin@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Extensions: Fix sidebar icons by including iron-icons.html

Extensions relied on cr_search_field including iron-icons for icons that
extensions uses. Instead Extensions should import iron-icons directly.

BUG=609424
R=rdevlin.cronin@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[michaelpg, 2016-05-05 15:33:20]

PTAL, fixes the regression at
https://bugs.chromium.org/p/chromium/issues/detail?id=609424

[Devlin, 2016-05-05 15:55:01]

I had a fix for this last night, and just didn't send it out.  Teach me to lag.

https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/icons.html (right):

https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/icons.html:2: <link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
Shouldn't this be imported by sidebar.html instead?

[michaelpg, 2016-05-05 16:10:15]

https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md...
File chrome/browser/resources/md_extensions/icons.html (right):

https://codereview.chromium.org/1950303002/diff/1/chrome/browser/resources/md...
chrome/browser/resources/md_extensions/icons.html:2: <link rel="import"
href="chrome://resources/polymer/v1_0/iron-icons/iron-icons.html">
On 2016/05/05 15:55:01, Devlin wrote:
> Shouldn't this be imported by sidebar.html instead?

I'm ambivalent: either make icons.html the "hub" which lists and imports all the
icons Extensions uses, or import iron-icons.html from any file which uses
iron-icons.

Feel free to push your fix instead.

[Devlin, 2016-05-05 17:00:05]

On 2016/05/05 16:10:15, michaelpg wrote:
> Feel free to push your fix instead.

Okay, will take this one.