mash: Add status area container to mash window manager

mash: Add status area container to mash window manager

Previously the ash status container and the ash shelf containers were both
mapped to the mash "user shelf" container. However, the "status" container
container includes both the status area widget and popups for status
notifications (e.g. message center notifications, screenshot taken, etc.).

Creating a separate container allows existing ash code running on mus to test
if a particular widget is in the status container and not the shelf container.
This is needed for the system tray bubble code.

BUG=599142
TEST=existing mash_unittests, manually set shelf position to left/bottom/right

Committed: https://crrev.com/0127a907b020c66d437da23e7b1539b80c7784a7
Cr-Commit-Position: refs/heads/master@{#392062}

[James Cook, 2016-05-05 20:43:01]

jamescook@chromium.org changed reviewers:
+ msw@chromium.org

[James Cook, 2016-05-05 20:43:02]

msw, please take a look

[msw, 2016-05-05 21:20:26]

lgtm with nits

https://codereview.chromium.org/1950293003/diff/1/mash/wm/shelf_layout_manage...
File mash/wm/shelf_layout_manager.cc (right):

https://codereview.chromium.org/1950293003/diff/1/mash/wm/shelf_layout_manage...
mash/wm/shelf_layout_manager.cc:29: const mojom::AshWindowType ash_window_type =
GetAshWindowType(window);
nit: inline this in the conditional below.

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
File mash/wm/status_layout_manager.cc (right):

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
mash/wm/status_layout_manager.cc:29: const mojom::AshWindowType ash_window_type
= GetAshWindowType(window);
nit: inline this in the conditional below.

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
mash/wm/status_layout_manager.cc:30: gfx::Size size =
GetWindowPreferredSize(window);
nit: move this after the early return.

[James Cook, 2016-05-05 22:09:08]

jamescook@chromium.org changed reviewers:
+ sky@chromium.org

[James Cook, 2016-05-05 22:09:09]

sky, can I get OWNERS for ash/mus/sysui_application.cc ?

https://codereview.chromium.org/1950293003/diff/1/mash/wm/shelf_layout_manage...
File mash/wm/shelf_layout_manager.cc (right):

https://codereview.chromium.org/1950293003/diff/1/mash/wm/shelf_layout_manage...
mash/wm/shelf_layout_manager.cc:29: const mojom::AshWindowType ash_window_type =
GetAshWindowType(window);
On 2016/05/05 21:20:26, msw wrote:
> nit: inline this in the conditional below.

Done.

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
File mash/wm/status_layout_manager.cc (right):

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
mash/wm/status_layout_manager.cc:29: const mojom::AshWindowType ash_window_type
= GetAshWindowType(window);
On 2016/05/05 21:20:26, msw wrote:
> nit: inline this in the conditional below.

Done.

https://codereview.chromium.org/1950293003/diff/1/mash/wm/status_layout_manag...
mash/wm/status_layout_manager.cc:30: gfx::Size size =
GetWindowPreferredSize(window);
On 2016/05/05 21:20:26, msw wrote:
> nit: move this after the early return.

Done.

[sky, 2016-05-05 23:56:34]

LGTM

[James Cook, 2016-05-06 15:25:37]

The CQ bit was checked by jamescook@chromium.org

[James Cook, 2016-05-06 15:25:37]

The patchset sent to the CQ was uploaded after l-g-t-m from msw@chromium.org
Link to the patchset: https://codereview.chromium.org/1950293003/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-05-06 15:25:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950293003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950293003/20001

[commit-bot: I haz the power, 2016-05-06 15:38:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-06 15:40:07]

Description was changed from

==========
mash: Add status area container to mash window manager

Previously the ash status container and the ash shelf containers were both
mapped to the mash "user shelf" container. However, the "status" container
container includes both the status area widget and popups for status
notifications (e.g. message center notifications, screenshot taken, etc.).

Creating a separate container allows existing ash code running on mus to test
if a particular widget is in the status container and not the shelf container.
This is needed for the system tray bubble code.

BUG=599142
TEST=existing mash_unittests, manually set shelf position to left/bottom/right
==========

to

==========
mash: Add status area container to mash window manager

Previously the ash status container and the ash shelf containers were both
mapped to the mash "user shelf" container. However, the "status" container
container includes both the status area widget and popups for status
notifications (e.g. message center notifications, screenshot taken, etc.).

Creating a separate container allows existing ash code running on mus to test
if a particular widget is in the status container and not the shelf container.
This is needed for the system tray bubble code.

BUG=599142
TEST=existing mash_unittests, manually set shelf position to left/bottom/right

Committed: https://crrev.com/0127a907b020c66d437da23e7b1539b80c7784a7
Cr-Commit-Position: refs/heads/master@{#392062}
==========

[commit-bot: I haz the power, 2016-05-06 15:40:08]

Patchset 2 (id:??) landed as
https://crrev.com/0127a907b020c66d437da23e7b1539b80c7784a7
Cr-Commit-Position: refs/heads/master@{#392062}