Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 1950283002: Convert track-remove* tests to testharness.js (Closed)

Created:
4 years, 7 months ago by Srirama
Modified:
4 years, 7 months ago
CC:
blink-reviews, chromium-reviews, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert track-remove* tests to testharness.js Cleaning up track-remove* tests in media/track to use testharness.js instead of video-test.js. This will enable to upstream these tests to web-platform-tests. BUG=588956 Committed: https://crrev.com/4e8d672b8e5d2c1e3f81eb9a14d7cb6199d73526 Cr-Commit-Position: refs/heads/master@{#392060}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments #

Messages

Total messages: 12 (6 generated)
Srirama
PTAL
4 years, 7 months ago (2016-05-05 14:03:31 UTC) #3
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1950283002/diff/1/third_party/WebKit/LayoutTests/media/track/track-removal-crash.html File third_party/WebKit/LayoutTests/media/track/track-removal-crash.html (right): https://codereview.chromium.org/1950283002/diff/1/third_party/WebKit/LayoutTests/media/track/track-removal-crash.html#newcode19 third_party/WebKit/LayoutTests/media/track/track-removal-crash.html:19: setTimeout(CFcrash, 10); step_func? https://codereview.chromium.org/1950283002/diff/1/third_party/WebKit/LayoutTests/media/track/track-removal-crash.html#newcode27 third_party/WebKit/LayoutTests/media/track/track-removal-crash.html:27: setTimeout(runGCAndEndTest, 0); step_func_done ...
4 years, 7 months ago (2016-05-06 12:58:28 UTC) #4
Srirama
https://codereview.chromium.org/1950283002/diff/1/third_party/WebKit/LayoutTests/media/track/track-removal-crash.html File third_party/WebKit/LayoutTests/media/track/track-removal-crash.html (right): https://codereview.chromium.org/1950283002/diff/1/third_party/WebKit/LayoutTests/media/track/track-removal-crash.html#newcode19 third_party/WebKit/LayoutTests/media/track/track-removal-crash.html:19: setTimeout(CFcrash, 10); On 2016/05/06 12:58:28, Mounir Lamouri wrote: > ...
4 years, 7 months ago (2016-05-06 14:17:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950283002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950283002/20001
4 years, 7 months ago (2016-05-06 14:17:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-06 15:20:57 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-06 15:23:12 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4e8d672b8e5d2c1e3f81eb9a14d7cb6199d73526
Cr-Commit-Position: refs/heads/master@{#392060}

Powered by Google App Engine
This is Rietveld 408576698