Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950253003: Enable hermetic builds for FYI mac builders. (Closed)

Created:
4 years, 7 months ago by justincohen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Reland of Enable hermetic builds for FYI mac builders. (patchset #1 id:1 of https://codereview.chromium.org/1946023004/ ) Reason for revert: Try this CL again now that the sudoers change has been applied via puppet. Original issue's description: > Revert of Enable hermetic builds for FYI mac builders. (patchset #2 id:20001 of https://codereview.chromium.org/1942383002/ ) > > Reason for revert: > This broke a bunch of FYI bots. > > Original issue's description: > > Enable hermetic builds for FYI mac builders. > > > > BUG=474373 > > > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300441 > > TBR=phajdan.jr@chromium.org,dpranke@chromium.org,erikchen@chromium.org,shrike@chromium.org,smut@google.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=474373 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300448 TBR=phajdan.jr@chromium.org,dpranke@chromium.org,erikchen@chromium.org,shrike@chromium.org,smut@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=474373 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=300469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -328 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 13 chunks +32 lines, -31 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_10_MacViews.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11.json View 3 chunks +3 lines, -0 lines 0 comments Download
D scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_11_Force_Mac_Toolchain.json View 1 chunk +0 lines, -297 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__clobber_.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg_.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Chromium_Mac_10_9_Goma_Canary__dbg__clobber_.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMacASan_tester.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac__dbg_.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTMac_tester.json View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Mac_OpenSSL.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Print_Preview_Mac.json View 3 chunks +3 lines, -0 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_macviews.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
justincohen
Created Reland of Enable hermetic builds for FYI mac builders.
4 years, 7 months ago (2016-05-06 00:30:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950253003/1
4 years, 7 months ago (2016-05-06 00:30:25 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 7 months ago (2016-05-06 00:30:27 UTC) #5
justincohen
PTAL smut@
4 years, 7 months ago (2016-05-06 00:30:48 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 7 months ago (2016-05-06 15:59:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950253003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950253003/1
4 years, 7 months ago (2016-05-06 16:00:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=300469
4 years, 7 months ago (2016-05-06 16:04:17 UTC) #11
justincohen
4 years, 7 months ago (2016-05-06 16:21:24 UTC) #12
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1943993008/ by justincohen@chromium.org.

The reason for reverting is: Looks like sudoers still not working on FYI bots..

Powered by Google App Engine
This is Rietveld 408576698