Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 1950253002: Remove Source/platform/image-encoders/skia (Closed)

Created:
4 years, 7 months ago by Noel Gordon
Modified:
4 years, 7 months ago
CC:
chromium-reviews, blink-reviews, jzern, kinuko+watch, skal, urvang, scroggo_chromium, msarett1, xlai (Olivia)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Source/platform/image-encoders/skia The "skia" is no longer needed since we only use Skia in Blink. Move the image encoders up a directory level, adjust #includes. Minor: fix presubmit upload nit in PNGImageEncoder.cpp. No change in behavior, no new tests. BUG=439655 Committed: https://crrev.com/5f52d011f7437a00026c205d56c96cd7fdeb174e Cr-Commit-Position: refs/heads/master@{#391756}

Patch Set 1 : Initial patch. #

Patch Set 2 : Fix compile: adjust platform and core file #includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -641 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/LoggingCanvas.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/PictureSnapshot.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/JPEGImageEncoder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/JPEGImageEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/PNGImageEncoder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/PNGImageEncoder.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/WEBPImageEncoder.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/Source/platform/image-encoders/WEBPImageEncoder.cpp View 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/JPEGImageEncoder.cpp View 1 chunk +0 lines, -219 lines 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/PNGImageEncoder.h View 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/PNGImageEncoder.cpp View 1 chunk +0 lines, -115 lines 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.h View 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/Source/platform/image-encoders/skia/WEBPImageEncoder.cpp View 1 chunk +0 lines, -93 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950253002/20001
4 years, 7 months ago (2016-05-05 02:29:22 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/155694)
4 years, 7 months ago (2016-05-05 02:38:20 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950253002/40001
4 years, 7 months ago (2016-05-05 02:50:18 UTC) #11
Noel Gordon
4 years, 7 months ago (2016-05-05 03:45:54 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-05 04:02:58 UTC) #15
Timothy Loh
lgtm
4 years, 7 months ago (2016-05-05 04:38:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950253002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950253002/40001
4 years, 7 months ago (2016-05-05 04:39:56 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 7 months ago (2016-05-05 04:44:12 UTC) #21
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 04:45:13 UTC) #23
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5f52d011f7437a00026c205d56c96cd7fdeb174e
Cr-Commit-Position: refs/heads/master@{#391756}

Powered by Google App Engine
This is Rietveld 408576698