cc/animation/animation_host_unittest.cc - Issue 1950243005: Communicate MT changes to impl-only scroll offset animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/animation/animation_host_unittest.cc

Issue 1950243005: Communicate MT changes to impl-only scroll offset animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address review comments Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/animation/animation_host.cc ('K') | « cc/animation/animation_host_perftest.cc ('k') | cc/animation/animation_player_unittest.cc » ('j') | third_party/WebKit/Source/platform/animation/CompositorAnimationHost.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/animation/animation_host_unittest.cc

diff --git a/cc/animation/animation_host_unittest.cc b/cc/animation/animation_host_unittest.cc

index aa477bfeb70e138e90907195185cb1a934ff393d..e16c82a025d6fdf051f53a2acca18651cd093970 100644

--- a/cc/animation/animation_host_unittest.cc

+++ b/cc/animation/animation_host_unittest.cc

@@ -37,20 +37,20 @@ TEST_F(AnimationHostTest, SyncTimelinesAddRemove) {

EXPECT_FALSE(host_impl->GetTimelineById(timeline_id));

- host->PushPropertiesTo(host_impl.get());

+ host->PushPropertiesTo(host_impl.get(), base::TimeTicks());

scoped_refptr<AnimationTimeline> timeline_impl =

host_impl->GetTimelineById(timeline_id);

EXPECT_TRUE(timeline_impl);

EXPECT_EQ(timeline_impl->id(), timeline_id);

- host->PushPropertiesTo(host_impl.get());

+ host->PushPropertiesTo(host_impl.get(), base::TimeTicks());

EXPECT_EQ(timeline_impl, host_impl->GetTimelineById(timeline_id));

host->RemoveAnimationTimeline(timeline.get());

EXPECT_FALSE(timeline->animation_host());

- host->PushPropertiesTo(host_impl.get());

+ host->PushPropertiesTo(host_impl.get(), base::TimeTicks());

EXPECT_FALSE(host_impl->GetTimelineById(timeline_id));

EXPECT_FALSE(timeline_impl->animation_host());

@@ -74,7 +74,7 @@ TEST_F(AnimationHostTest, ImplOnlyTimeline) {

host->AddAnimationTimeline(timeline.get());

host_impl->AddAnimationTimeline(timeline_impl.get());

- host->PushPropertiesTo(host_impl.get());

+ host->PushPropertiesTo(host_impl.get(), base::TimeTicks());

EXPECT_TRUE(host->GetTimelineById(timeline_id1));

EXPECT_TRUE(host_impl->GetTimelineById(timeline_id2));