Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp

Issue 1950243005: Communicate MT changes to impl-only scroll offset animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: attempt to fix rebase issue Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
diff --git a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
index 679f5a6e598f7cd7b292fba1d710d8fb06348147..60cbd81283394626de3ce6814cdfbb45b4814a1d 100644
--- a/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
+++ b/third_party/WebKit/Source/platform/scroll/ScrollAnimatorTest.cpp
@@ -519,4 +519,33 @@ TEST(ScrollAnimatorTest, CancellingCompositorAnimation)
ThreadHeap::collectAllGarbage();
}
+// This test verifies that ImplOnlyAnimationUpdate gets cleared once its
+// pushed to compositor animation host.
+TEST(ScrollAnimatorTest, ImplOnlyAnimationUpdatesCleared)
+{
+ MockScrollableArea* scrollableArea = MockScrollableArea::create(true);
+ TestScrollAnimator* animator = new TestScrollAnimator(scrollableArea, getMockedTime);
+
+ EXPECT_CALL(*scrollableArea, registerForAnimation()).Times(2);
+
+ EXPECT_EQ(animator->m_runState, ScrollAnimatorCompositorCoordinator::RunState::Idle);
+ EXPECT_FALSE(animator->hasAnimationThatRequiresService());
+ EXPECT_TRUE(animator->implOnlyAnimationAdjustmentForTesting().isZero());
+
+ animator->updateImplOnlyScrollOffsetAnimation(FloatSize(100.f, 100.f));
+ animator->updateImplOnlyScrollOffsetAnimation(FloatSize(10.f, -10.f));
+
+ EXPECT_TRUE(animator->hasAnimationThatRequiresService());
+ EXPECT_EQ(FloatSize(110.f, 90.f), animator->implOnlyAnimationAdjustmentForTesting());
+
+ animator->updateCompositorAnimations();
+
+ EXPECT_EQ(animator->m_runState, ScrollAnimatorCompositorCoordinator::RunState::Idle);
+ EXPECT_FALSE(animator->hasAnimationThatRequiresService());
+ EXPECT_TRUE(animator->implOnlyAnimationAdjustmentForTesting().isZero());
+
+ // Forced GC in order to finalize objects depending on the mock object.
+ ThreadHeap::collectAllGarbage();
+}
+
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/platform/scroll/ScrollAnimatorCompositorCoordinator.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698