third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h - Issue 1950243005: Communicate MT changes to impl-only scroll offset animations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h

Issue 1950243005: Communicate MT changes to impl-only scroll offset animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: attempt to fix rebase issue Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/animation/CompositorAnimationHostTest.cpp ('k') | third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h

diff --git a/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h b/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h

index 1d9f0667dc6354f8b3cbb17ad0deb832fd19d93a..323ab4aef79fac945fbbed39cf30d2faf959bc3f 100644

--- a/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h

+++ b/third_party/WebKit/Source/platform/animation/CompositorAnimationTimeline.h

@@ -14,9 +14,10 @@

namespace blink {

+class CompositorAnimationHost;

class CompositorAnimationPlayerClient;

-// A compositor representation for timeline.

+// A compositor representation for cc::AnimationTimeline.

class PLATFORM_EXPORT CompositorAnimationTimeline {

WTF_MAKE_NONCOPYABLE(CompositorAnimationTimeline);

public:

@@ -24,6 +25,10 @@ public:

virtual ~CompositorAnimationTimeline();

cc::AnimationTimeline* animationTimeline() const;

+ // TODO(ymalik): Currently we just wrap cc::AnimationHost in

+ // CompositorAnimationHost. Correctly introduce CompositorAnimationHost

+ // to blink. See crbug.com/610763.

+ CompositorAnimationHost compositorAnimationHost();

virtual void playerAttached(const CompositorAnimationPlayerClient&);

virtual void playerDestroyed(const CompositorAnimationPlayerClient&);