Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Side by Side Diff: cc/animation/scroll_offset_animations.h

Issue 1950243005: Communicate MT changes to impl-only scroll offset animations (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: apply initial feedback comments Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CC_ANIMATION_SCROLL_OFFSET_ANIMATIONS_H_
6 #define CC_ANIMATION_SCROLL_OFFSET_ANIMATIONS_H_
7
8 #include "cc/animation/scroll_offset_animations_impl.h"
9 #include "cc/trees/mutator_host_client.h"
10
11 namespace cc {
12
13 // A ScrollOffsetAnimationUpdate represents a change on the main thread
14 // that may impact an impl-only scroll offset animation. PushPropertiesTo is
skobes 2016/05/07 00:25:16 The comment about PushPropertiesTo would make more
ymalik 2016/05/10 19:40:59 Done.
15 // called during commit time and the necessary update is made to the impl-only
16 // animation.
17 // Note that this class only exists on the main thread.
18 struct CC_EXPORT ScrollOffsetAnimationUpdate {
19 enum Type { SCROLL_OFFSET_CHANGED };
20
21 ScrollOffsetAnimationUpdate();
skobes 2016/05/07 00:25:16 Add a ctor with params to initialize the fields?
ymalik 2016/05/10 19:40:59 Done.
22
23 // The element to which this update applies.
24 ElementId element_id_;
25 Type type_;
26
27 // The amount by which the scroll offset is changed on the main thread.
28 gfx::Vector2dF adjustment_;
29 };
30
31 class CC_EXPORT ScrollOffsetAnimations {
32 public:
33 explicit ScrollOffsetAnimations(AnimationHost* animation_host);
34 ~ScrollOffsetAnimations();
35
36 void AddUpdate(ScrollOffsetAnimationUpdate);
37 bool HasUpdatesForTesting() const;
38
39 // Goes through the updates in the order in which they're added and calls the
40 // appropriate handler for each update.
41 void PushPropertiesTo(ScrollOffsetAnimationsImpl*,
42 base::TimeTicks frame_monotonic_time);
43
44 private:
45 using UpdatesQueue = std::vector<ScrollOffsetAnimationUpdate>;
46 UpdatesQueue queue_;
47
48 AnimationHost* animation_host_;
49 };
50
51 } // namespace cc
52
53 #endif // CC_ANIMATION_SCROLL_OFFSET_ANIMATIONS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698