Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1950223002: [Media Router WebUI] Don't let pseudo sinks alone show user email. (Closed)

Created:
4 years, 7 months ago by btolsch
Modified:
4 years, 7 months ago
Reviewers:
apacible
CC:
chromium-reviews, media-router+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router WebUI] Don't let pseudo sinks alone show user email. This change prevents the presence of pseudo sinks with a domain from showing a signed-in user's email in the MR dialog when there are no other sinks with a domain. BUG=609299 R=apacible@chromium.org Committed: https://crrev.com/d57ef78ca4c6ef7f325c1865a04af57616f1a617 Cr-Commit-Position: refs/heads/master@{#391844}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/media_router/media_router_webui_message_handler_unittest.cc View 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
btolsch
PTAL, thanks!
4 years, 7 months ago (2016-05-04 22:42:39 UTC) #1
apacible
lgtm
4 years, 7 months ago (2016-05-05 17:41:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950223002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950223002/1
4 years, 7 months ago (2016-05-05 18:07:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 18:13:20 UTC) #5
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 18:14:39 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d57ef78ca4c6ef7f325c1865a04af57616f1a617
Cr-Commit-Position: refs/heads/master@{#391844}

Powered by Google App Engine
This is Rietveld 408576698