Issue 19502003: Cut some more dependencies from browser to child for multiple_dll mode

Issue 19502003: Cut some more dependencies from browser to child for multiple_dll mode (Closed)

Created:
7 years, 5 months ago by scottmg

Modified:
7 years, 5 months ago

Reviewers:
jam, sky

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Cut some more dependencies from browser to child for multiple_dll mode Removes the in-process implementations for Gpu and Utility. R=jam@chromium.org, sky@chromium.org BUG=237249 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213126

Patch Set 2 : . #

Total comments: 2

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -7 lines)			Patch
M	chrome/app/chrome_main_delegate.cc	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/gpu/gpu_process_host.cc	View		4 chunks	+8 lines, -1 line	0 comments	Download
M	content/browser/utility_process_host_impl.h	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/browser/utility_process_host_impl.cc	View	1	3 chunks	+8 lines, -1 line	2 comments	Download
M	content/content.gyp	View	1	3 chunks	+3 lines, -1 line	0 comments	Download
M	ui/views/controls/webview/webview.gyp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

scottmg

jam: chrome/ and content/ sky: ui/views/controls/webview/webview.gyp

7 years, 5 months ago (2013-07-23 03:38:10 UTC) #1

jam

lgtm https://codereview.chromium.org/19502003/diff/3001/content/browser/utility_process_host_impl.cc File content/browser/utility_process_host_impl.cc (right): https://codereview.chromium.org/19502003/diff/3001/content/browser/utility_process_host_impl.cc#newcode199 content/browser/utility_process_host_impl.cc:199: // Multiple nit: comment cut off?

7 years, 5 months ago (2013-07-23 15:19:36 UTC) #3

scottmg

https://codereview.chromium.org/19502003/diff/3001/content/browser/utility_process_host_impl.cc File content/browser/utility_process_host_impl.cc (right): https://codereview.chromium.org/19502003/diff/3001/content/browser/utility_process_host_impl.cc#newcode199 content/browser/utility_process_host_impl.cc:199: // Multiple On 2013/07/23 15:19:36, jam wrote: > nit: ...

7 years, 5 months ago (2013-07-23 15:33:15 UTC) #4

scottmg

7 years, 5 months ago (2013-07-23 15:33:44 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r213126 (presubmit successful).

Expand Messages | Collapse Messages