Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1950183002: Add two missing tests to gn build (Closed)

Created:
4 years, 7 months ago by brucedawson
Modified:
4 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add two missing tests to gn build BUG=604060 Committed: https://crrev.com/737b128f6945bd40959db05e8abec9012076a247 Cr-Commit-Position: refs/heads/master@{#391637}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M content/test/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brucedawson
These tests are in gyp builds but not gn builds which seems like a bad ...
4 years, 7 months ago (2016-05-04 19:31:16 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-04 19:33:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950183002/1
4 years, 7 months ago (2016-05-04 19:35:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:55:12 UTC) #6
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:56:49 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/737b128f6945bd40959db05e8abec9012076a247
Cr-Commit-Position: refs/heads/master@{#391637}

Powered by Google App Engine
This is Rietveld 408576698