Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1950173002:
Now we're on MSVC 2015, try using std::chrono for timing again. (Closed)
DescriptionNow we're on MSVC 2015, try using std::chrono for timing again.
2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code.
Tested this locally on Windows 10 and Mac (the two affected platforms).
Long term SkTime::GetNSecs() can probably be phased out for direct <chrono> use.
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1950173002
Committed: https://skia.googlesource.com/skia/+/f2509381bdd9e712919418f7ebe831f974208154
Patch Set 1 #
Messages
Total messages: 18 (12 generated)
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. BUG=skia: ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
The CQ bit was checked by mtklein@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950173002/1
The CQ bit was unchecked by mtklein@chromium.org
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac (the two affected platforms). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + herb@google.com
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac (the two affected platforms). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac (the two affected platforms). Long term SkTime::GetNSecs() can probably be phased out for direct <chrono> use. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ==========
mtklein@chromium.org changed reviewers: + reed@google.com
+reed
lgtm
The CQ bit was checked by mtklein@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950173002/1
Message was sent while issue was closed.
Description was changed from ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac (the two affected platforms). Long term SkTime::GetNSecs() can probably be phased out for direct <chrono> use. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... ========== to ========== Now we're on MSVC 2015, try using std::chrono for timing again. 2015's std::chrono::high_resolution_clock should have a precision equal to our old custom code. Tested this locally on Windows 10 and Mac (the two affected platforms). Long term SkTime::GetNSecs() can probably be phased out for direct <chrono> use. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is... Committed: https://skia.googlesource.com/skia/+/f2509381bdd9e712919418f7ebe831f974208154 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/f2509381bdd9e712919418f7ebe831f974208154 |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
