Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Unified Diff: chrome/browser/chrome_service_worker_browsertest.cc

Issue 1950133009: DevTools: account for the display scale factor while validating manifest under emulation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comment addressed Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_service_worker_browsertest.cc
diff --git a/chrome/browser/chrome_service_worker_browsertest.cc b/chrome/browser/chrome_service_worker_browsertest.cc
index fca044785b2b6e7a4eedfdcf662840e23eea01f2..8d054fc64659d88a29cd2d5840b2fade6b70de58 100644
--- a/chrome/browser/chrome_service_worker_browsertest.cc
+++ b/chrome/browser/chrome_service_worker_browsertest.cc
@@ -273,8 +273,8 @@ class ChromeServiceWorkerManifestFetchTest
}
std::string RequestAppBannerAndGetIssuedRequests() {
- EXPECT_TRUE(browser()->RequestAppBanner(
- browser()->tab_strip_model()->GetActiveWebContents()));
+ browser()->RequestAppBannerFromDevTools(
+ browser()->tab_strip_model()->GetActiveWebContents());
return ExecuteScriptAndExtractString(
"if (issuedRequests.length != 0) reportRequests();"
"else reportOnFetch = true;");

Powered by Google App Engine
This is Rietveld 408576698