Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issue 1950133002: Fix cloning of generic function types when applying mixin members to mixin (Closed)

Created:
4 years, 7 months ago by regis
Modified:
4 years, 7 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix cloning of generic function types when applying mixin members to mixin application class (fixes #26387). R=hausner@google.com Committed: https://github.com/dart-lang/sdk/commit/4eb2144956bea901ce5115442f6f8442f4d33ada

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -6 lines) Patch
M runtime/vm/object.cc View 2 chunks +27 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
4 years, 7 months ago (2016-05-04 17:54:50 UTC) #2
hausner
LGTM (Looks Greek To Me)
4 years, 7 months ago (2016-05-04 18:30:09 UTC) #3
regis
On 2016/05/04 18:30:09, hausner wrote: > LGTM (Looks Greek To Me) ευχαριστώ
4 years, 7 months ago (2016-05-04 18:31:20 UTC) #4
regis
4 years, 7 months ago (2016-05-04 18:34:06 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4eb2144956bea901ce5115442f6f8442f4d33ada (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698