Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2472)

Unified Diff: appengine/findit/common/git_repository.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/common/git_repository.py
diff --git a/appengine/findit/common/git_repository.py b/appengine/findit/common/git_repository.py
index a1fb155b28606fbc067ee7988e9f5548ccb135f2..cb3a5cd06ff07e37914d9c7a7ac4da2d0c91bd60 100644
--- a/appengine/findit/common/git_repository.py
+++ b/appengine/findit/common/git_repository.py
@@ -44,7 +44,7 @@ class GitRepository(Repository):
return self.repo_url
@Cached(namespace='Gitiles-json-view', expire_time=CACHE_EXPIRE_TIME_SECONDS)
- def _SendRequestForJsonResponse(self, url, params=None):
+ def _SendRequestForJsonResponse(self, url, params=None, headers=None):
stgao 2016/05/05 21:02:47 It seems not clean for the GitRepository to know a
Sharu Jiang 2016/05/05 23:03:45 Done.
if params is None: # pragma: no cover
params = {}
params['format'] = 'json'
@@ -52,7 +52,7 @@ class GitRepository(Repository):
# Gerrit prepends )]}' to json-formatted response.
prefix = ')]}\'\n'
- status_code, content = self.http_client.Get(url, params)
+ status_code, content = self.http_client.Get(url, params, headers=headers)
if status_code != 200:
return None
elif not content or not content.startswith(prefix):
@@ -61,8 +61,9 @@ class GitRepository(Repository):
return json.loads(content[len(prefix):])
@Cached(namespace='Gitiles-text-view', expire_time=CACHE_EXPIRE_TIME_SECONDS)
- def _SendRequestForTextResponse(self, url):
- status_code, content = self.http_client.Get(url, {'format': 'text'})
+ def _SendRequestForTextResponse(self, url, headers=None):
+ status_code, content = self.http_client.Get(url, {'format': 'text'},
+ headers=headers)
if status_code != 200:
return None
return base64.b64decode(content)
@@ -257,3 +258,11 @@ class GitRepository(Repository):
changelogs.append(changelog)
return changelogs
+
+ def GetRevisionForChromeVersion(self, version):
+ """Gets the githash revision of a chrome version."""
+ changelog = self.GetChangeLog(version)
+ if not changelog:
+ return None
+
+ return changelog.revision

Powered by Google App Engine
This is Rietveld 408576698