appengine/findit/crash/test/fracas_parser_test.py - Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/test/fracas_parser_test.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Add signature filtering. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/crash/fracas_parser.py ('K') | « appengine/findit/crash/test/fracas_crash_pipeline_test.py ('k') | appengine/findit/crash/test/fracas_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/crash/test/fracas_parser_test.py

diff --git a/appengine/findit/crash/test/fracas_parser_test.py b/appengine/findit/crash/test/fracas_parser_test.py

index 0cebee4005601abfe6dfc79a5cb4c1087d8372ca..fc0f9c1443b1c6cdcb2afe02dedc5645da030863 100644

--- a/appengine/findit/crash/test/fracas_parser_test.py

+++ b/appengine/findit/crash/test/fracas_parser_test.py

@@ -31,7 +31,7 @@ class FracasParserTest(StacktraceTestSuite):

#1 [RESTRICTED]

"""

)

- self._VerifyTwoStacktracesEqual(parser.Parse(stacktrace_string, deps),

+ self._VerifyTwoStacktracesEqual(parser.Parse(stacktrace_string, deps, ''),

Stacktrace())

def testFracasParserParseLineOneCallstack(self):

@@ -46,7 +46,7 @@ class FracasParserTest(StacktraceTestSuite):

"""

)

- stacktrace = parser.Parse(stacktrace_string, deps)

+ stacktrace = parser.Parse(stacktrace_string, deps, '')

expected_callstack = CallStack(0)

expected_callstack.extend(

@@ -74,7 +74,7 @@ class FracasParserTest(StacktraceTestSuite):

"""

)

- stacktrace = parser.Parse(stacktrace_string, deps)

+ stacktrace = parser.Parse(stacktrace_string, deps, '')

expected_callstack0 = CallStack(0)

expected_callstack0.extend(