appengine/findit/crash/stacktrace_parser.py - Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/stacktrace_parser.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Add signature filtering. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« appengine/findit/crash/fracas_parser.py ('K') | « appengine/findit/crash/scorers/test/aggregator_test.py ('k') | appengine/findit/crash/test/callstack_filters_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: appengine/findit/crash/stacktrace_parser.py

diff --git a/appengine/findit/crash/stacktrace_parser.py b/appengine/findit/crash/stacktrace_parser.py

index cb37490bafd36741eebada98b9401e182c0cbb52..f261f03597cbbbca88274d0a87a99b5a518208c2 100644

--- a/appengine/findit/crash/stacktrace_parser.py

+++ b/appengine/findit/crash/stacktrace_parser.py

@@ -5,7 +5,7 @@

class StacktraceParser(object):

- def Parse(self, stacktrace_string, deps):

+ def Parse(self, stacktrace_string, deps, signature):

raise NotImplementedError()

def _IsStartOfNewCallStack(self, line):