Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2918)

Unified Diff: appengine/findit/crash/fracas_parser.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Add signature filtering. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/fracas_parser.py
diff --git a/appengine/findit/crash/fracas_parser.py b/appengine/findit/crash/fracas_parser.py
index a4b967270c99c7ef55d0f4b71052fca4ce3efef4..ff5531d76d076b6a43a3d25075c022fc2429fb6d 100644
--- a/appengine/findit/crash/fracas_parser.py
+++ b/appengine/findit/crash/fracas_parser.py
@@ -5,6 +5,7 @@
import re
from crash.callstack import CallStack
+from crash.callstack_filters import SignatureFilter
from crash.stacktrace import Stacktrace
from crash.stacktrace_parser import StacktraceParser
from crash.type_enums import CallStackFormatType
@@ -18,7 +19,7 @@ _INFINITY_PRIORITY = 1000
class FracasParser(StacktraceParser):
- def Parse(self, stacktrace_string, deps):
+ def Parse(self, stacktrace_string, deps, signature):
Martin Barbella 2016/05/06 22:50:55 Should signature be optional? In the tests, it see
Martin Barbella 2016/05/06 22:51:59 s/empty signatures/empty string signatures/
stgao 2016/05/06 23:15:11 +1
Sharu Jiang 2016/05/06 23:43:46 Done.
"""Parse fracas stacktrace string into Stacktrace instance."""
stacktrace = Stacktrace()
callstack = CallStack(_INFINITY_PRIORITY)
@@ -40,6 +41,8 @@ class FracasParser(StacktraceParser):
if callstack.priority != _INFINITY_PRIORITY and callstack:
stacktrace.append(callstack)
+ # Filter all the frames before signature frame.
+ SignatureFilter(stacktrace.GetCrashStack(), signature)
return stacktrace
def _IsStartOfNewCallStack(self, line):

Powered by Google App Engine
This is Rietveld 408576698