Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(521)

Unified Diff: appengine/findit/common/test/dependency_test.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Address comments. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/common/test/dependency_test.py
diff --git a/appengine/findit/common/test/dependency_test.py b/appengine/findit/common/test/dependency_test.py
index c879f52b95910c2148d3d6689ef55c37c75f032d..b2f27558a7ed3d7559c37cdf53e43fe711dca34a 100644
--- a/appengine/findit/common/test/dependency_test.py
+++ b/appengine/findit/common/test/dependency_test.py
@@ -45,6 +45,14 @@ class DependencyTest(unittest.TestCase):
sub_dep.SetParent(root_dep)
self.assertEqual(expected_dep_tree_dict, root_dep.ToDict())
+ def testDependencyForChromeVersion(self):
+ dep = Dependency(
+ 'a/b/', 'https://cr.googlesource.com/cr/b.git', '12b', 'DEPS',
+ deps_repo_url='https://chrome-internal', deps_repo_revision='master')
+
+ self.assertNotEqual(dep.deps_repo_url, dep.repo_url)
stgao 2016/05/06 19:11:24 How about asserting against the expected values?
Sharu Jiang 2016/05/06 20:27:27 Done.
+ self.assertNotEqual(dep.deps_repo_revision, dep.revision)
+
class DependencyRollTest(unittest.TestCase):
def testToDict(self):

Powered by Google App Engine
This is Rietveld 408576698