[Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

appengine/findit/crash/fracas_crash_pipeline.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import base64
 import datetime
 import json
 import logging
 
 from google.appengine.ext import ndb
@@ skipping 37 matching lines @@
 
     # Update analysis status.
     analysis.pipeline_status_path = self.pipeline_status_path()
     analysis.status = analysis_status.RUNNING
     analysis.started_time = datetime.datetime.utcnow()
     analysis.findit_version = appengine_util.GetCurrentVersion()
     analysis.put()
 
     # Run the analysis.
     result, tags = fracas.FindCulpritForChromeCrash(
-        analysis.channel, analysis.platform, analysis.signature,
-        analysis.stack_trace, analysis.crashed_version,
-        analysis.historic_metadata)
+        analysis.signature, analysis.platform, analysis.stack_trace,
+        analysis.crashed_version, analysis.historic_metadata)
 
     # Update analysis status and save the analysis result.
     analysis.completed_time = datetime.datetime.utcnow()
     analysis.result = result
     for tag_name, tag_value in tags.iteritems():
       # TODO(http://crbug.com/602702): make it possible to add arbitrary tags.
       if hasattr(analysis, tag_name):
         setattr(analysis, tag_name, tag_value)
     analysis.status = analysis_status.COMPLETED
     analysis.put()
 
 
 class PublishResultPipeline(FracasBasePipeline):
   def finalized(self):
     if self.was_aborted:  # pragma: no cover.
       logging.error('Failed to publish analysis result for %s',
                     repr(self.crash_identifiers))
 
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(self, crash_identifiers):
     analysis = FracasCrashAnalysis.Get(crash_identifiers)
     result = {
         'crash_identifiers': crash_identifiers,

[stgao, 2016/05/05 17:32:28]

Should we include the ``client_id`` here too?
This is not urgent although.

[Sharu Jiang, 2016/05/05 20:26:45]

Done.

         'result': analysis.result,
     }
     messages_data = [json.dumps(result, sort_keys=True)]
 
     crash_config = CrashConfig.Get()
     topic = crash_config.fracas['analysis_result_pubsub_topic']
     pubsub_util.PublishMessagesToTopic(messages_data, topic)
     logging.info('Published analysis result for %s', repr(crash_identifiers))
 
 
 class FracasCrashWrapperPipeline(BasePipeline):
   # Arguments number differs from overridden method - pylint: disable=W0221
   def run(self, crash_identifiers):
     run_analysis = yield FracasAnalysisPipeline(crash_identifiers)
     with pipeline.After(run_analysis):
       yield PublishResultPipeline(crash_identifiers)
 
 
 @ndb.transactional
 def _NeedsNewAnalysis(
     crash_identifiers, chrome_version, signature, client_id,
     platform, stack_trace, channel, historic_metadata):
   analysis = FracasCrashAnalysis.Get(crash_identifiers)
   if analysis and not analysis.failed:
     # A new analysis is not needed if last one didn't complete or succeeded.
     # TODO(http://crbug.com/600535): re-analyze if stack trace or regression
     # range changed.
-    print 'lala'
     return False
 
   if not analysis:
     # A new analysis is needed if there is no analysis yet.
     analysis = FracasCrashAnalysis.Create(crash_identifiers)
 
   analysis.Reset()
 
   # Set common properties.
   analysis.crashed_version = chrome_version
@@ skipping 29 matching lines @@
   if _NeedsNewAnalysis(crash_identifiers, chrome_version, signature, client_id,
                        platform, stack_trace, channel, historic_metadata):
     analysis_pipeline = FracasCrashWrapperPipeline(crash_identifiers)
     analysis_pipeline.target = appengine_util.GetTargetNameForModule(
         constants.CRASH_BACKEND_FRACAS)
     analysis_pipeline.start(queue_name=queue_name)
     logging.info('New analysis is scheduled for %s', repr(crash_identifiers))
     return True
 
   return False