appengine/findit/crash/callstack_filters.py - Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: appengine/findit/crash/callstack_filters.py

Issue 1950123003: [Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Add signature filtering. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 # Copyright 2016 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 import re

	6

	7

	8 def SignatureFilter(callstack, signature):

	9 """Filter all the stack frames before the signature frame."""
	Martin Barbella 2016/05/06 22:50:54 This class name could be improved to better reflec This class name could be improved to better reflect what it actually does, though off the top of my head I can't think of a concise one. As-is, you really need to read this to know. Sharu Jiang 2016/05/06 23:43:46 Change it to FilterFramesBeforeSignature. Show quoted text On 2016/05/06 22:50:54, Martin Barbella wrote: > This class name could be improved to better reflect what it actually does, > though off the top of my head I can't think of a concise one. As-is, you really > need to read this to know. Change it to FilterFramesBeforeSignature.
	10 if not signature:

	11 return

	12

	13 signature_frame_index = 0

	14 # Filter out the types of signature, for exampel [Out of Memery] signature.
	Martin Barbella 2016/05/06 22:50:55 Nit: example and Memory, also no need for the last Nit: example and Memory, also no need for the last "signature". Sharu Jiang 2016/05/06 23:43:46 Done. Show quoted text On 2016/05/06 22:50:55, Martin Barbella wrote: > Nit: example and Memory, also no need for the last "signature". Done.
	15 signature = re.sub('[[][^]][]]\s', '', signature)

	16

	17 for index, frame in enumerate(callstack):

	18 if signature in frame.function:

	19 signature_frame_index = index

	20

	21 callstack[:] = callstack[signature_frame_index:]
	stgao 2016/05/06 23:15:11 How about returning a new list instead of updating How about returning a new list instead of updating in-place? Sharu Jiang 2016/05/06 23:43:46 Can I keep it in-place? Since I want to do: Filter Show quoted text On 2016/05/06 23:15:11, stgao wrote: > How about returning a new list instead of updating in-place? Can I keep it in-place? Since I want to do: FilterFramesBeforeSignature(stacktrace.GetCrashStack(), signature) This way would be simpler. stgao 2016/05/07 00:02:53 If it can't be avoided, let's make the docstring c Show quoted text On 2016/05/06 23:43:46, sharu jiang wrote: > On 2016/05/06 23:15:11, stgao wrote: > > How about returning a new list instead of updating in-place? > > Can I keep it in-place? Since I want to do: > FilterFramesBeforeSignature(stacktrace.GetCrashStack(), signature) > > This way would be simpler. If it can't be avoided, let's make the docstring clear that the input parameter is updated.
OLD	NEW

« no previous file with comments | « appengine/findit/common/test/deps_parser_test.py ('k') | appengine/findit/crash/fracas.py » ('j') | appengine/findit/crash/fracas_parser.py » ('J')