[Findit] Fetch DEPS from buildspec/ instead of trunk for chrome official builds.

appengine/findit/common/http_client_appengine.py

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import json
 import logging
 
 from google.appengine.api import urlfetch
 
+from common import auth_util
 from common.retry_http_client import RetryHttpClient
 
+_CHROME_INTERNAL_HOST = 'https://chrome-internal.googlesource.com'

[stgao, 2016/05/06 19:11:24]

Is it better for this to be a list?

[Sharu Jiang, 2016/05/06 20:27:27]

Done.

+
 
 class HttpClientAppengine(RetryHttpClient):  # pragma: no cover
   """A http client for running on appengine."""
+
+  def _GetExpandedHeaders(self, url, headers):

[stgao, 2016/05/06 19:11:24]

nit: this function is only for adding Oauth2.0 token, right?

[Sharu Jiang, 2016/05/06 20:27:27]

Done.

+    #TODO(katesonia): Move this to config.

[stgao, 2016/05/06 19:11:24]

nit: The host above needs to be moved to config, not this function.

[Sharu Jiang, 2016/05/06 20:27:27]

Done.

+    host_to_expanded_headers = {
+        _CHROME_INTERNAL_HOST: {
+            'Authorization': 'Bearer ' + auth_util.GetAuthToken()}

[stgao, 2016/05/06 19:11:24]

This might involve an api request, and is only useful for a subset of all http
requests. We should do it on demand.

[Sharu Jiang, 2016/05/06 20:27:27]

Done.

+    }
+
+    if not headers:
+      headers = {}
+
+    for host, expanded_headers in host_to_expanded_headers.iteritems():
+      if url.startswith(host):
+        return headers.update(expanded_headers)
+
+    return headers
+
   def _ShouldLogError(self, status_code):
     if not self.no_error_logging_statuses:
       return True
     return status_code not in self.no_error_logging_statuses
 
   def _SendRequest(self, url, method, data, timeout, headers=None):
     # We wanted to validate certificate to avoid the man in the middle.
-    if not headers:
-      headers = {}
+    headers = self._GetExpandedHeaders(url, headers)
+
     if method in (urlfetch.POST, urlfetch.PUT):
       result = urlfetch.fetch(
           url, payload=data, method=method,
           headers=headers, deadline=timeout, validate_certificate=True)
     else:
       result = urlfetch.fetch(
           url, headers=headers, deadline=timeout, validate_certificate=True)
 
     if (result.status_code != 200 and self._ShouldLogError(result.status_code)):
       logging.error('Request to %s resulted in %d, headers:%s', url,
                     result.status_code, json.dumps(result.headers.items()))
 
     return result.status_code, result.content
 
   def _Get(self, url, timeout, headers):
     return self._SendRequest(url, urlfetch.GET, None, timeout, headers)
 
   def _Post(self, url, data, timeout, headers):
     return self._SendRequest(url, urlfetch.POST, data, timeout, headers)
 
   def _Put(self, url, data, timeout, headers):
     return self._SendRequest(url, urlfetch.PUT, data, timeout, headers)