Enable XFA forms in the PDF plugin.

Enable XFA forms in the PDF plugin.

This CL enables the XFA forms functionality in both GYP and GN builds.

BUG=chromium:62400
Committed: https://crrev.com/08e9434b6f4938517755815da37752b0cd906be7
Cr-Commit-Position: refs/heads/master@{#393870}

[dsinclair, 2016-05-04 17:49:17]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-05-04 17:49:18]

PTAL.

[Tom Sepez, 2016-05-04 17:52:00]

lgtm

[dsinclair, 2016-05-04 18:08:45]

thakis@ for OWNERS

[dsinclair, 2016-05-04 18:09:04]

dsinclair@chromium.org changed reviewers:
+ thakis@chromium.org

[dsinclair, 2016-05-04 18:09:05]

thakis@ for OWNERS.

[dsinclair, 2016-05-16 17:14:01]

ping

[Nico, 2016-05-16 17:20:43]

lgtm

[dsinclair, 2016-05-16 17:21:12]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-05-16 17:21:12]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1950123002/#ps20001
(title: "Rebase to master")

[Nico, 2016-05-16 17:21:37]

This is for collecting perf and stability data again, yes? There were concerns
about size and whatnot the last time (if this is supposed to be permanent -- I
was told eng review would talk about that)

[commit-bot: I haz the power, 2016-05-16 17:21:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1950123002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1950123002/20001

[dsinclair, 2016-05-16 17:23:21]

On 2016/05/16 17:21:37, Nico wrote:
> This is for collecting perf and stability data again, yes? There were concerns
> about size and whatnot the last time (if this is supposed to be permanent -- I
> was told eng review would talk about that)


Yea, we an turn it off again when we're about to branch.

[commit-bot: I haz the power, 2016-05-16 18:21:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-16 18:24:49]

Description was changed from

==========
Enable XFA forms in the PDF plugin.

This CL enables the XFA forms functionality in both GYP and GN builds.

BUG=chromium:62400
==========

to

==========
Enable XFA forms in the PDF plugin.

This CL enables the XFA forms functionality in both GYP and GN builds.

BUG=chromium:62400

Committed: https://crrev.com/08e9434b6f4938517755815da37752b0cd906be7
Cr-Commit-Position: refs/heads/master@{#393870}
==========

[commit-bot: I haz the power, 2016-05-16 18:24:50]

Patchset 2 (id:??) landed as
https://crrev.com/08e9434b6f4938517755815da37752b0cd906be7
Cr-Commit-Position: refs/heads/master@{#393870}

[aizatsky, 2016-05-16 21:03:54]

It seems that this CL broke CFI build. Could you take a look?

https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/2...

../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/third_party/pdfium/fxge/fx_ge_ps.o.d -DV8_DEPRECATION_WARNINGS
-DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
-DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
-DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV
-DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
-DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1
-DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1
-DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
-DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_TOPCHROME_MD=1
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
-DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
-DCR_CLANG_REVISION=268813-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
-D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
-DCFI_ENFORCEMENT -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
-DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DV8_DEPRECATION_WARNINGS
-DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -D_FX_CPU_=_FX_X64_ -I../.. -Igen
-I../../third_party/pdfium
-I../../third_party/pdfium/third_party/freetype/include
-I../../third_party/pdfium/third_party/freetype/include/freetype
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -funwind-tables
-fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
-fcolor-diagnostics -fdebug-prefix-map=/b/build/slave/CFI_Linux_ToT/build/src=.
-flto -pthread -m64 -march=x86-64 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template -O2 -fno-ident
-fdata-sections -ffunction-sections -g0
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot -fno-omit-frame-pointer
-fsanitize=cfi-vcall -fsanitize=cfi-derived-cast -fsanitize=cfi-unrelated-cast
-fsanitize-blacklist=../../tools/cfi/blacklist.txt -fvisibility=hidden -Xclang
-load -Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang
check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang
check-ipc -Wheader-hygiene -Wstring-conversion -Wno-switch -fPIC
-Wno-sign-compare -fno-threadsafe-statics -fvisibility-inlines-hidden
-std=gnu++11 -fno-rtti -fno-exceptions -c
../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp -o
obj/third_party/pdfium/fxge/fx_ge_ps.o
In file included from ../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp:7:
In file included from ../../third_party/pdfium/core/fxge/include/fx_ge.h:10:
In file included from ../../third_party/pdfium/core/fxge/include/fx_dib.h:12:
../../third_party/pdfium/core/fxcrt/include/fx_basic.h:267:28: error: binding
dereferenced null pointer to reference has undefined behavior
[-Werror,-Wnull-dereference]
      return (const TYPE&)(*(volatile const TYPE*)NULL);
                           ^~~~~~~~~~~~~~~~~~~~~~~~~~~
../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp:88:30: note: in instantiation
of member function 'CFX_ArrayTemplate<FX_RECT>::GetAt' requested here
  m_ClipBox = m_ClipBoxStack.GetAt(m_ClipBoxStack.GetSize() - 1);
                             ^
1 error generated.

[Nico, 2016-05-16 21:04:46]

On 2016/05/16 21:03:54, aizatsky wrote:
> It seems that this CL broke CFI build. Could you take a look?
> 
>
https://build.chromium.org/p/chromium.fyi/builders/CFI%20Linux%20ToT/builds/2...
> 
> ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
> obj/third_party/pdfium/fxge/fx_ge_ps.o.d -DV8_DEPRECATION_WARNINGS
> -DENABLE_MDNS=1 -DENABLE_NOTIFICATIONS -DENABLE_PEPPER_CDMS -DENABLE_PLUGINS=1
> -DENABLE_PDF=1 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1
> -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DUSE_UDEV
> -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_PANGO=1 -DUSE_CAIRO=1
> -DUSE_CLIPBOARD_AURAX11=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_GLIB=1
> -DUSE_NSS_CERTS=1 -DUSE_X11=1 -DENABLE_WEBRTC=1 -DENABLE_EXTENSIONS=1
> -DENABLE_TASK_MANAGER=1 -DENABLE_THEMES=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
> -DENABLE_SESSION_SERVICE=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1
> -DENABLE_SUPERVISED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1
-DENABLE_TOPCHROME_MD=1
> -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL
> -DCHROMIUM_BUILD -DENABLE_MEDIA_ROUTER=1 -DFIELDTRIAL_TESTING_ENABLED
> -DCR_CLANG_REVISION=268813-1 -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE
> -D_LARGEFILE64_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS
> -DCFI_ENFORCEMENT -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0
> -DOPJ_STATIC -DPNG_PREFIX -DPNG_USE_READ_MACROS -DV8_DEPRECATION_WARNINGS
> -DPDF_ENABLE_V8 -DPDF_ENABLE_XFA -D_FX_CPU_=_FX_X64_ -I../.. -Igen
> -I../../third_party/pdfium
> -I../../third_party/pdfium/third_party/freetype/include
> -I../../third_party/pdfium/third_party/freetype/include/freetype
> -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-funwind-tables
> -fPIC -pipe -B../../third_party/binutils/Linux_x64/Release/bin
> -fcolor-diagnostics
-fdebug-prefix-map=/b/build/slave/CFI_Linux_ToT/build/src=.
> -flto -pthread -m64 -march=x86-64 -Wall -Werror -Wextra
> -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
> -Wno-covered-switch-default -Wno-deprecated-register
> -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
> -Wno-shift-negative-value -Wno-undefined-var-template -O2 -fno-ident
> -fdata-sections -ffunction-sections -g0
> --sysroot=../../build/linux/debian_wheezy_amd64-sysroot
-fno-omit-frame-pointer
> -fsanitize=cfi-vcall -fsanitize=cfi-derived-cast -fsanitize=cfi-unrelated-cast
> -fsanitize-blacklist=../../tools/cfi/blacklist.txt -fvisibility=hidden -Xclang
> -load -Xclang
> ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so
-Xclang
> -add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs
> -Xclang check-templates -Xclang -plugin-arg-find-bad-constructs -Xclang
> follow-macro-expansion -Xclang -plugin-arg-find-bad-constructs -Xclang
> check-implicit-copy-ctors -Xclang -plugin-arg-find-bad-constructs -Xclang
> check-ipc -Wheader-hygiene -Wstring-conversion -Wno-switch -fPIC
> -Wno-sign-compare -fno-threadsafe-statics -fvisibility-inlines-hidden
> -std=gnu++11 -fno-rtti -fno-exceptions -c
> ../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp -o
> obj/third_party/pdfium/fxge/fx_ge_ps.o
> In file included from ../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp:7:
> In file included from ../../third_party/pdfium/core/fxge/include/fx_ge.h:10:
> In file included from ../../third_party/pdfium/core/fxge/include/fx_dib.h:12:
> ../../third_party/pdfium/core/fxcrt/include/fx_basic.h:267:28: error: binding
> dereferenced null pointer to reference has undefined behavior
> [-Werror,-Wnull-dereference]
>       return (const TYPE&)(*(volatile const TYPE*)NULL);
>                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~
> ../../third_party/pdfium/core/fxge/ge/fx_ge_ps.cpp:88:30: note: in
instantiation
> of member function 'CFX_ArrayTemplate<FX_RECT>::GetAt' requested here
>   m_ClipBox = m_ClipBoxStack.GetAt(m_ClipBoxStack.GetSize() - 1);
>                              ^
> 1 error generated.

No, I think that's a new clang warning -- you're probably using clang tot on
that bot? If so, https://codereview.chromium.org/1982763002/ will fix that.