Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 1950103002: Update README to use GN instead of GYP (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Update README to use GN instead of GYP This Cl updates the README so GN is the recommended method to build PDFium in a standalone fashion. BUG=pdfium:485 Committed: https://pdfium.googlesource.com/pdfium/+/ab522f9e05291d6d915a40174e3cb5f7509c449b

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -44 lines) Patch
M README.md View 1 2 3 7 chunks +31 lines, -44 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-04 17:28:28 UTC) #2
Tom Sepez
https://codereview.chromium.org/1950103002/diff/1/README.md File README.md (right): https://codereview.chromium.org/1950103002/diff/1/README.md#newcode10 README.md:10: Add a news item for GN change. I think ...
4 years, 7 months ago (2016-05-04 17:34:07 UTC) #3
dsinclair
https://codereview.chromium.org/1950103002/diff/1/README.md File README.md (right): https://codereview.chromium.org/1950103002/diff/1/README.md#newcode10 README.md:10: On 2016/05/04 17:34:07, Tom Sepez wrote: > Add a ...
4 years, 7 months ago (2016-05-04 17:38:50 UTC) #4
Tom Sepez
lgtm https://codereview.chromium.org/1950103002/diff/40001/README.md File README.md (right): https://codereview.chromium.org/1950103002/diff/40001/README.md#newcode5 README.md:5: As of 2016-05-04, GN is used to generate ...
4 years, 7 months ago (2016-05-04 18:00:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950103002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950103002/60001
4 years, 7 months ago (2016-05-04 18:10:57 UTC) #8
dsinclair
https://codereview.chromium.org/1950103002/diff/40001/README.md File README.md (right): https://codereview.chromium.org/1950103002/diff/40001/README.md#newcode5 README.md:5: As of 2016-05-04, GN is used to generate build ...
4 years, 7 months ago (2016-05-04 18:11:10 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 18:23:56 UTC) #11
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/ab522f9e05291d6d915a40174e3cb5f7509c...

Powered by Google App Engine
This is Rietveld 408576698