Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 1950093002: Fix gpu_ipc_service_unittests on android release gn builds (Closed)

Created:
4 years, 7 months ago by Mark Dittmer
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, Fady Samuel
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix gpu_ipc_service_unittests on android release gn builds BUG=604935 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/753fb9df926342654794f7e2c87fcdc7bc0b7fdc Cr-Commit-Position: refs/heads/master@{#391794}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -8 lines) Patch
M gpu/ipc/service/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/service/gpu_channel_unittest.cc View 3 chunks +6 lines, -8 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950093002/1
4 years, 7 months ago (2016-05-04 17:01:05 UTC) #3
Mark Dittmer
Surprisingly, rebasing https://codereview.chromium.org/1908013002 identified new failures due to missing dep and more tests requiring the ...
4 years, 7 months ago (2016-05-04 17:02:49 UTC) #6
Mark Dittmer
piman@, PTAL.
4 years, 7 months ago (2016-05-04 17:03:02 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-04 18:16:43 UTC) #9
piman
lgtm
4 years, 7 months ago (2016-05-04 21:26:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1950093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1950093002/1
4 years, 7 months ago (2016-05-05 13:42:54 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-05 13:46:21 UTC) #14
commit-bot: I haz the power
4 years, 7 months ago (2016-05-05 13:47:45 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/753fb9df926342654794f7e2c87fcdc7bc0b7fdc
Cr-Commit-Position: refs/heads/master@{#391794}

Powered by Google App Engine
This is Rietveld 408576698