Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5975)

Unified Diff: chrome/test/BUILD.gn

Issue 1950003002: gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix gn runtime deps check error on missing mash target on linux and win8. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/BUILD.gn
diff --git a/chrome/test/BUILD.gn b/chrome/test/BUILD.gn
index 26bb379a84cf9c3a55ea48d126640ca08c45eb9f..a086cd2b2970172a6000e31c416faffed4bc6188 100644
--- a/chrome/test/BUILD.gn
+++ b/chrome/test/BUILD.gn
@@ -401,7 +401,9 @@ if (!is_android) {
# TODO(rockot) bug 505926: The chrome_extensions_interactive_uitests target
# should be deleted and this line removed. See the
# chrome_extensions_interactive_uitests target for more.
- deps += [ "//extensions:chrome_extensions_interactive_uitests" ]
+ if (enable_extensions) {
+ deps += [ "//extensions:chrome_extensions_interactive_uitests" ]
+ }
# Runtime dependencies
data_deps += [
@@ -920,7 +922,6 @@ if (!is_android) {
"//chrome:strings",
"//chrome/browser",
"//chrome/browser/resources:extension_resource_demo",
- "//chrome/common/extensions/api",
"//chrome/renderer",
"//components/autofill/content/browser:risk_proto",
"//components/autofill/content/renderer:test_support",
@@ -939,7 +940,6 @@ if (!is_android) {
"//crypto:test_support",
"//device/bluetooth:mocks",
"//device/serial:test_support",
- "//extensions/common/api",
"//google_apis:test_support",
"//media",
"//media/base:test_support",
@@ -968,11 +968,19 @@ if (!is_android) {
"//ui/web_dialogs:test_support",
"//v8",
]
+ if (enable_extensions) {
+ deps += [
+ "//chrome/common/extensions/api",
+ "//extensions/common/api",
+ ]
+ }
# TODO(rockot) bug 505926: The chrome_extensions_browsertests target should
# be deleted and this line removed. See the chrome_extensions_browsertests
# target for more.
- deps += [ "//extensions:chrome_extensions_browsertests" ]
+ if (enable_extensions) {
+ deps += [ "//extensions:chrome_extensions_browsertests" ]
+ }
# Runtime dependencies
data_deps = [

Powered by Google App Engine
This is Rietveld 408576698