Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Side by Side Diff: BUILD.gn

Issue 1950003002: gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Moving deps inclusion and disabling extensions for chromecast Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | chrome/browser/media/router/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 126 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 ] 137 ]
138 } 138 }
139 139
140 if (!is_ios && !is_android && !is_chromecast) { 140 if (!is_ios && !is_android && !is_chromecast) {
141 deps += [ 141 deps += [
142 "//chrome", 142 "//chrome",
143 "//chrome/test:browser_tests", 143 "//chrome/test:browser_tests",
144 "//chrome/test:interactive_ui_tests", 144 "//chrome/test:interactive_ui_tests",
145 "//chrome/test:sync_integration_tests", 145 "//chrome/test:sync_integration_tests",
146 "//chrome/test/chromedriver:chromedriver_unittests", 146 "//chrome/test/chromedriver:chromedriver_unittests",
147 "//extensions:extensions_browsertests",
148 "//extensions:extensions_unittests",
149 "//gpu/gles2_conform_support:gles2_conform_test", 147 "//gpu/gles2_conform_support:gles2_conform_test",
150 "//jingle:jingle_unittests", 148 "//jingle:jingle_unittests",
151 "//net:hpack_example_generator", 149 "//net:hpack_example_generator",
152 "//net:hpack_fuzz_mutator", 150 "//net:hpack_fuzz_mutator",
153 "//net:hpack_fuzz_wrapper", 151 "//net:hpack_fuzz_wrapper",
154 "//ppapi:ppapi_unittests", 152 "//ppapi:ppapi_unittests",
155 "//ppapi/examples/2d", 153 "//ppapi/examples/2d",
156 "//ppapi/examples/audio", 154 "//ppapi/examples/audio",
157 "//ppapi/examples/audio_input", 155 "//ppapi/examples/audio_input",
158 "//ppapi/examples/compositor", 156 "//ppapi/examples/compositor",
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
246 "//ios/third_party/earl_grey", 244 "//ios/third_party/earl_grey",
247 "//ios/web:ios_web_inttests", 245 "//ios/web:ios_web_inttests",
248 "//ios/web:ios_web_unittests", 246 "//ios/web:ios_web_unittests",
249 "//ios/web/shell:ios_web_shell", 247 "//ios/web/shell:ios_web_shell",
250 ] 248 ]
251 } 249 }
252 250
253 deps += root_extra_deps 251 deps += root_extra_deps
254 252
255 if (enable_extensions) { 253 if (enable_extensions) {
256 deps += [ "//extensions/shell:app_shell_unittests" ] 254 deps += [
255 "//extensions:extensions_browsertests",
256 "//extensions:extensions_unittests",
257 "//extensions/shell:app_shell",
258 "//extensions/shell:app_shell_unittests",
259 ]
257 } 260 }
258 261
259 if (enable_media_router) { 262 if (enable_media_router) {
260 deps += [ "//chrome/browser/media/router" ] 263 deps += [ "//chrome/browser/media/router" ]
261 } 264 }
262 265
263 if (enable_remoting) { 266 if (enable_remoting) {
264 deps += [ "//remoting:remoting_all" ] 267 deps += [ "//remoting:remoting_all" ]
265 } 268 }
266 269
267 if (toolkit_views) { 270 if (toolkit_views) {
268 deps += [ "//ui/views:views_unittests" ] 271 deps += [ "//ui/views:views_unittests" ]
269 } 272 }
270 273
271 if (use_aura) { 274 if (use_aura) {
272 deps += [ 275 deps += [
273 "//ash:ash_shell_with_content",
274 "//ash:ash_unittests",
275 "//ui/app_list/presenter:app_list_presenter_unittests", 276 "//ui/app_list/presenter:app_list_presenter_unittests",
276 "//ui/aura:aura_unittests", 277 "//ui/aura:aura_unittests",
277 "//ui/aura:demo", 278 "//ui/aura:demo",
278 "//ui/wm:wm_unittests", 279 "//ui/wm:wm_unittests",
279 ] 280 ]
281 if (use_ash) {
282 deps += [
283 "//ash:ash_shell_with_content",
284 "//ash:ash_unittests",
285 ]
286 }
280 } 287 }
281 288
282 if (use_ozone) { 289 if (use_ozone) {
283 deps += [ "//ui/ozone" ] 290 deps += [ "//ui/ozone" ]
284 } 291 }
285 292
286 if (use_x11) { 293 if (use_x11) {
287 deps += [ "//tools/xdisplaycheck" ] 294 deps += [ "//tools/xdisplaycheck" ]
288 } 295 }
289 296
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 "//third_party/leveldatabase:env_chromium_unittests", 483 "//third_party/leveldatabase:env_chromium_unittests",
477 "//third_party/libaddressinput:libaddressinput_unittests", 484 "//third_party/libaddressinput:libaddressinput_unittests",
478 ] 485 ]
479 } 486 }
480 if (!is_android && !is_linux) { 487 if (!is_android && !is_linux) {
481 # TODO(dpranke): Re-enable this once 488 # TODO(dpranke): Re-enable this once
482 # https://chromium-review.googlesource.com/#/c/312298/1 is rolled 489 # https://chromium-review.googlesource.com/#/c/312298/1 is rolled
483 # into chromium. 490 # into chromium.
484 deps += [ "//third_party/angle/src/tests:angle_end2end_tests" ] 491 deps += [ "//third_party/angle/src/tests:angle_end2end_tests" ]
485 } 492 }
486
487 if (enable_extensions) {
488 deps += [ "//extensions/shell:app_shell" ]
489 }
490
491 if (enable_nacl) { 493 if (enable_nacl) {
492 deps += [ "//components/nacl/loader:nacl_loader_unittests" ] 494 deps += [ "//components/nacl/loader:nacl_loader_unittests" ]
493 495
494 if (is_linux) { 496 if (is_linux) {
495 # TODO(dpranke): Figure out what platforms should actually have this. 497 # TODO(dpranke): Figure out what platforms should actually have this.
496 deps += [ 498 deps += [
497 "//components/nacl/loader:helper_nonsfi", 499 "//components/nacl/loader:helper_nonsfi",
498 "//components/nacl/loader:nacl_helper", 500 "//components/nacl/loader:nacl_helper",
499 "//components/nacl/loader:nacl_helper_nonsfi_unittests", 501 "//components/nacl/loader:nacl_helper_nonsfi_unittests",
500 ] 502 ]
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
644 646
645 if (!is_android && !is_ios && !is_chromeos) { 647 if (!is_android && !is_ios && !is_chromeos) {
646 deps += [ "//components/proximity_auth:proximity_auth_unittests" ] 648 deps += [ "//components/proximity_auth:proximity_auth_unittests" ]
647 } 649 }
648 650
649 if (is_win || is_linux) { 651 if (is_win || is_linux) {
650 deps += [ 652 deps += [
651 "//components/mus/demo", 653 "//components/mus/demo",
652 "//components/mus/ws:tests", 654 "//components/mus/ws:tests",
653 "//components/resource_provider:resource_provider_unittests", 655 "//components/resource_provider:resource_provider_unittests",
654 "//mash:all",
655 "//media/mojo/services:media_mojo_shell_unittests", 656 "//media/mojo/services:media_mojo_shell_unittests",
656 "//mojo", 657 "//mojo",
657 "//ui/views/mus:views_mus_unittests", 658 "//ui/views/mus:views_mus_unittests",
658 ] 659 ]
660 if (use_ash) {
661 deps += [ "//mash:all" ]
662 }
659 } 663 }
660 664
661 if (is_linux && !is_chromeos && !is_chromecast) { 665 if (is_linux && !is_chromeos && !is_chromecast) {
662 # TODO(GYP): Figure out if any of these should be in gn_all 666 # TODO(GYP): Figure out if any of these should be in gn_all
663 # and figure out how cross-platform they are 667 # and figure out how cross-platform they are
664 deps += [ 668 deps += [
665 ":gn_mojo_targets", 669 ":gn_mojo_targets",
666 "//chrome/browser/resources:extension_resource_demo", 670 "//chrome/browser/resources:extension_resource_demo",
667 "//chrome/installer/util:strings", 671 "//chrome/installer/util:strings",
668 "//chrome/tools/convert_dict", 672 "//chrome/tools/convert_dict",
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 assert(target_name != "") # Mark as used. 956 assert(target_name != "") # Mark as used.
953 sources = invoker.actual_sources 957 sources = invoker.actual_sources
954 assert( 958 assert(
955 sources == invoker.actual_sources, 959 sources == invoker.actual_sources,
956 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 960 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
957 } 961 }
958 962
959 assert_valid_out_dir("_unused") { 963 assert_valid_out_dir("_unused") {
960 actual_sources = [ "$root_build_dir/foo" ] 964 actual_sources = [ "$root_build_dir/foo" ]
961 } 965 }
OLDNEW
« no previous file with comments | « no previous file | build/config/features.gni » ('j') | chrome/browser/media/router/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698