Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Side by Side Diff: build/config/features.gni

Issue 1950003002: gn BUILD fixes for disabling enable_extensions and use_ash feature flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebasing on latest master Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/devtools/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file contains Chrome-feature-related build flags (see ui.gni for 5 # This file contains Chrome-feature-related build flags (see ui.gni for
6 # UI-related ones). These should theoretically be moved to the build files of 6 # UI-related ones). These should theoretically be moved to the build files of
7 # the features themselves. 7 # the features themselves.
8 # 8 #
9 # However, today we have many "bad" dependencies on some of these flags from, 9 # However, today we have many "bad" dependencies on some of these flags from,
10 # e.g. base, so they need to be global to match the GYP configuration. Also, 10 # e.g. base, so they need to be global to match the GYP configuration. Also,
11 # anything that needs a grit define must be in either this file or ui.gni. 11 # anything that needs a grit define must be in either this file or ui.gni.
12 # 12 #
13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't 13 # PLEASE TRY TO AVOID ADDING FLAGS TO THIS FILE in cases where grit isn't
14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how 14 # required. See the declare_args block of BUILDCONFIG.gn for advice on how
15 # to set up feature flags. 15 # to set up feature flags.
16 16
17 import("//build/config/chrome_build.gni") 17 import("//build/config/chrome_build.gni")
18 import("//build/config/chromecast_build.gni") 18 import("//build/config/chromecast_build.gni")
19 if (is_android) { 19 if (is_android) {
20 import("//build/config/android/config.gni") 20 import("//build/config/android/config.gni")
21 } 21 }
22 22
23 declare_args() { 23 declare_args() {
24 # Multicast DNS. 24 # Multicast DNS.
25 enable_mdns = is_win || is_linux 25 enable_mdns = is_win || is_linux
26 26
27 enable_extensions = !is_android && !is_ios 27 enable_extensions = !is_android && !is_ios && !is_chromecast
28 enable_plugins = (!is_android && !is_ios) || is_chromecast 28 enable_plugins = (!is_android && !is_ios) || is_chromecast
29 enable_pdf = !is_android && !is_ios && !is_chromecast 29 enable_pdf = !is_android && !is_ios && !is_chromecast
30 30
31 # Enables Native Client support. 31 # Enables Native Client support.
32 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion. 32 # TODO(mcgrathr): When mipsel-nacl-clang is available, drop the exclusion.
33 enable_nacl = 33 enable_nacl =
34 !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel" 34 !is_ios && !is_android && !is_chromecast && current_cpu != "mipsel"
35 35
36 # If debug_devtools is set to true, JavaScript files for DevTools are stored 36 # If debug_devtools is set to true, JavaScript files for DevTools are stored
37 # as is and loaded from disk. Otherwise, a concatenated file is stored in 37 # as is and loaded from disk. Otherwise, a concatenated file is stored in
(...skipping 131 matching lines...) Expand 10 before | Expand all | Expand 10 after
169 use_brlapi = is_chromeos 169 use_brlapi = is_chromeos
170 170
171 # Enable WebVR support by default on Android 171 # Enable WebVR support by default on Android
172 # Still requires command line flag to access API 172 # Still requires command line flag to access API
173 enable_webvr = is_android 173 enable_webvr = is_android
174 174
175 enable_configuration_policy = !is_ios 175 enable_configuration_policy = !is_ios
176 176
177 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build 177 enable_mac_keystone = is_mac && is_chrome_branded && is_official_build
178 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build 178 enable_mac_crash_collection = is_mac && is_chrome_branded && is_official_build
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | chrome/browser/devtools/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698