gn BUILD fixes for disabling enable_extensions and use_ash feature flags.

BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This is the root build file for GN. GN will start processing by loading this
 # file, and recursively load all dependencies until all dependencies are either
 # resolved or known not to exist (which will cause the build to fail). So if
 # you add a new build file, there must be some path of dependencies from this
 # file to your new one or GN won't know about it.
 
@@ skipping 126 matching lines @@
     ]
   }
 
   if (!is_ios && !is_android && !is_chromecast) {
     deps += [
       "//chrome",
       "//chrome/test:browser_tests",
       "//chrome/test:interactive_ui_tests",
       "//chrome/test:sync_integration_tests",
       "//chrome/test/chromedriver:chromedriver_unittests",
-      "//extensions:extensions_browsertests",
-      "//extensions:extensions_unittests",
       "//gpu/gles2_conform_support:gles2_conform_test",
       "//jingle:jingle_unittests",
       "//net:hpack_example_generator",
       "//net:hpack_fuzz_mutator",
       "//net:hpack_fuzz_wrapper",
       "//ppapi:ppapi_unittests",
       "//ppapi/examples/2d",
       "//ppapi/examples/audio",
       "//ppapi/examples/audio_input",
       "//ppapi/examples/compositor",
@@ skipping 26 matching lines @@
       "//third_party/codesighs",
       "//third_party/pdfium/samples:pdfium_test",
       "//tools/battor_agent",
       "//tools/battor_agent:battor_agent_unittests",
       "//tools/gn",
       "//tools/gn:gn_unittests",
       "//tools/perf/clear_system_cache",
       "//ui/accessibility:accessibility_unittests",
       "//ui/app_list:app_list_unittests",
     ]
+    if (enable_extensions) {
+      deps += [
+        "//extensions:extensions_browsertests",
+        "//extensions:extensions_unittests",
+      ]
+    }

[Dirk Pranke, 2016/05/05 02:38:48]

Can you check if we can lift these blocks out of the os-specific if blocks,
since presumably enable_extensions and use_ash is not true on the platforms that
we're excluding?

[asaka, 2016/05/11 05:54:14]

I agree it sounds plausible, but I don't know how to verify it. Any suggestions
of targets/configurations I should test build?

From features.gni:
enable_extensions = !is_android && !is_ios

is_chromecast it also supported on is_linux afaict so I think I should test
build that if you can suggest the target?

   }
 
   if (!is_ios) {
     # TODO(GYP): Figure out which of these should actually build on iOS,
     # and whether there should be other targets that are iOS-only and missing.
     deps += [
       "//cc:cc_unittests",
       "//chrome/test:unit_tests",
       "//components:components_browsertests",
       "//content/shell:content_shell",
@@ skipping 58 matching lines @@
   if (enable_remoting) {
     deps += [ "//remoting:remoting_all" ]
   }
 
   if (toolkit_views) {
     deps += [ "//ui/views:views_unittests" ]
   }
 
   if (use_aura) {
     deps += [
-      "//ash:ash_shell_with_content",
-      "//ash:ash_unittests",
       "//ui/app_list/presenter:app_list_presenter_unittests",
       "//ui/aura:aura_unittests",
       "//ui/aura:demo",
       "//ui/wm:wm_unittests",
     ]
+    if (use_ash) {
+      deps += [
+        "//ash:ash_shell_with_content",
+        "//ash:ash_unittests",
+      ]
+    }
   }
 
   if (use_ozone) {
     deps += [ "//ui/ozone" ]
   }
 
   if (use_x11) {
     deps += [ "//tools/xdisplaycheck" ]
   }
 
@@ skipping 354 matching lines @@
 
   if (!is_android && !is_ios && !is_chromeos) {
     deps += [ "//components/proximity_auth:proximity_auth_unittests" ]
   }
 
   if (is_win || is_linux) {
     deps += [
       "//components/mus/demo",
       "//components/mus/ws:tests",
       "//components/resource_provider:resource_provider_unittests",
-      "//mash:all",
       "//media/mojo/services:media_mojo_shell_unittests",
       "//mojo",
       "//ui/views/mus:views_mus_unittests",
     ]
+    if (use_ash) {
+      deps += [ "//mash:all" ]
+    }
   }
 
   if (is_linux && !is_chromeos && !is_chromecast) {
     # TODO(GYP): Figure out if any of these should be in gn_all
     # and figure out how cross-platform they are
     deps += [
       ":gn_mojo_targets",
       "//chrome/browser/resources:extension_resource_demo",
       "//chrome/installer/util:strings",
       "//chrome/tools/convert_dict",
@@ skipping 283 matching lines @@
   assert(target_name != "")  # Mark as used.
   sources = invoker.actual_sources
   assert(
       sources == invoker.actual_sources,
       "Do not use a platform name in your output directory (found \"$root_build_dir\"). http://crbug.com/548283")
 }
 
 assert_valid_out_dir("_unused") {
   actual_sources = [ "$root_build_dir/foo" ]
 }