Implement basic point-and-touch mouse input for Android client

remoting/client/jni/chromoting_jni_instance.h

Index: remoting/client/jni/chromoting_jni_instance.h
diff --git a/remoting/client/jni/chromoting_jni_instance.h b/remoting/client/jni/chromoting_jni_instance.h
index 2374e24e7d1b1ba92f1ccc001ead0df4ead5434c..3ee7d4637a50124c80da9eb013a88723f3a6c4c5 100644
--- a/remoting/client/jni/chromoting_jni_instance.h
+++ b/remoting/client/jni/chromoting_jni_instance.h
@@ -19,13 +19,21 @@
 #include "remoting/client/jni/jni_frame_consumer.h"
 #include "remoting/jingle_glue/network_settings.h"
 #include "remoting/jingle_glue/xmpp_signal_strategy.h"
+#include "remoting/protocol/clipboard_stub.h"
 #include "remoting/protocol/connection_to_host.h"
+#include "remoting/protocol/cursor_shape_stub.h"
 
 namespace remoting {
+namespace protocol {
+  class ClipboardEvent;
+  class CursorShapeInfo;
+}  // namespace protocol
 
 // ClientUserInterface that indirectly makes and receives JNI calls.
 class ChromotingJniInstance
   : public ClientUserInterface,
+    public protocol::ClipboardStub,
+    public protocol::CursorShapeStub,
     public base::RefCountedThreadSafe<ChromotingJniInstance> {
  public:
   // Initiates a connection with the specified host. Call from the UI thread.
@@ -48,6 +56,13 @@ class ChromotingJniInstance
   // Schedules a redraw on the display thread. May be called from any thread.
   void RedrawDesktop();
 
+  // Moves the host's cursor to the specified coordinates, optionally with some
+  // mouse button depressed. If |button| is BUTTON_UNDEFINED, no click is made.
+  // A negative value of |button| releases the button described by -|button|.

[garykac, 2013/07/20 21:25:26]

Button press/release should be stored as a boolean rather than overloading the
button id in this manner.

The approach used here leads to code like:
   if (button.id < 0)
rather than:
   if (button.pressed)
The latter being much more readable.

Also, MouseEvent_MouseButton is an enum defined to have only positive values.
Storing invalid values here can lead to madness.

[solb, 2013/07/22 19:13:48]

Done.

+  void PerformMouseAction(int x,
+                          int y,
+                          protocol::MouseEvent_MouseButton button);
+
   // ClientUserInterface implementation.
   virtual void OnConnectionState(
       protocol::ConnectionToHost::State state,
@@ -61,6 +76,13 @@ class ChromotingJniInstance
   virtual scoped_ptr<protocol::ThirdPartyClientAuthenticator::TokenFetcher>
       GetTokenFetcher(const std::string& host_public_key) OVERRIDE;
 
+  // CursorShapeStub implementation.
+  virtual void InjectClipboardEvent(
+      const protocol::ClipboardEvent& event) OVERRIDE;
+
+  // ClipboardStub implementation.
+  virtual void SetCursorShape(const protocol::CursorShapeInfo& shape) OVERRIDE;
+
  private:
   // This object is ref-counted, so it cleans itself up.
   virtual ~ChromotingJniInstance();