Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1949963002: Revert of Re-enable complex text path on android (Closed)

Created:
4 years, 7 months ago by eae
Modified:
4 years, 7 months ago
Reviewers:
drott
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, dshwang, jbroman, Justin Novosad, Rik, Stephen Chennney, blink-reviews, f(malita), danakj+watch_chromium.org, kinuko+watch, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable complex text path on android (patchset #1 id:1 of https://codereview.chromium.org/1942223002/ ) Reason for revert: Caused a 5-7% memory regression. Original issue's description: > Re-enable complex text path on android > > Trying to re-enable the complex text path on Android now that hb-ot-font > is used for glyph lookups and the separate glyph cache has been removed. > > This should result in lower memory usage for the complex text code path, > we'll watch the memory bots though and revert as needed if it regresses. > > BUG=577306 > R=drott@chromium.org > > Committed: https://crrev.com/7e9bf5e20a53b0934944d5d40456ec7e7ea0815b > Cr-Commit-Position: refs/heads/master@{#391215} TBR=drott@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=577306 Committed: https://crrev.com/ddd30d4bfcbdfc494554c197162b37abd9bafbf8 Cr-Commit-Position: refs/heads/master@{#391457}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/platform/fonts/Font.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
eae
Created Revert of Re-enable complex text path on android
4 years, 7 months ago (2016-05-04 07:45:28 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949963002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949963002/1
4 years, 7 months ago (2016-05-04 07:45:39 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 07:46:04 UTC) #3
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 07:47:13 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddd30d4bfcbdfc494554c197162b37abd9bafbf8
Cr-Commit-Position: refs/heads/master@{#391457}

Powered by Google App Engine
This is Rietveld 408576698