Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3895)

Unified Diff: chrome/test/data/webui/settings/settings_menu_test.js

Issue 1949913002: [MD settings] restore side nav drop icons (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/settings_menu_test.js
diff --git a/chrome/test/data/webui/settings/settings_menu_test.js b/chrome/test/data/webui/settings/settings_menu_test.js
index 0a090fc0eb16d67ce08d2c4046e632c4930118c3..f2a3f0022168fafe6e8b4bc8f75ea134f0e38ba9 100644
--- a/chrome/test/data/webui/settings/settings_menu_test.js
+++ b/chrome/test/data/webui/settings/settings_menu_test.js
@@ -17,6 +17,22 @@ cr.define('settings_menu', function() {
teardown(function() { settingsMenu.remove(); });
+ test('upAndDownIcons', function() {
+ // There should be different icons for a top level menu being open
+ // vs. being closed. E.g. arrow-drop-up and arrow-drop-down.
+ settingsMenu.currentRoute = {
+ page: 'advanced', section: 'reset', subpage: []
+ };
+ var ironIconElement = settingsMenu.$.advancedPage.querySelector(
+ '.menu-trigger iron-icon');
+ assertTrue(!!ironIconElement);
+ var openIcon = ironIconElement.icon;
+ assertTrue(!!openIcon);
+ // Changing to basic will close advanced.
+ settingsMenu.currentRoute = {page: 'basic', section: '', subpage: []};
+ assertNotEquals(openIcon, ironIconElement.icon);
+ });
+
test('defaultToBasic', function() {
settingsMenu.currentRoute = {page: 'basic', section: '', subpage: []};
assertFalse(settingsMenu.$.advancedPage.opened);
« no previous file with comments | « chrome/browser/resources/settings/settings_menu/settings_menu.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698