Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1949893003: Convert ui::Event directly to blink::WebInputEvent. (Closed)

Created:
4 years, 7 months ago by Hadi
Modified:
4 years, 7 months ago
Reviewers:
rjkroege, sadrul, sky, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ui::Event directly to blink::WebInputEvent. In CompositorMusConnection::OnWindowInputEvent we need to convert ui::Event to blink::WebInputEvent. Previously we did this by first converting ui::Event to mojom::Event, and then using the mojom type converters we convert it to blink::WebInputEvent. We will remove the ui::Event to mojom::Event type converters. This CL adds support for direct conversion from ui::Event to blink::WebInputEvent. BUG=609138 Committed: https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f Cr-Commit-Position: refs/heads/master@{#392376}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : Fix windows compile error + Remove deprecated comment. #

Patch Set 6 : Fix linker error on win_chromium_x64_rel_ng #

Patch Set 7 : Another try to fix link error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+277 lines, -191 lines) Patch
M content/renderer/mus/compositor_mus_connection.cc View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M mojo/converters/blink/BUILD.gn View 1 2 3 4 5 6 2 chunks +21 lines, -1 line 0 comments Download
M mojo/converters/blink/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/converters/blink/blink_input_events_type_converters.h View 1 chunk +7 lines, -4 lines 0 comments Download
M mojo/converters/blink/blink_input_events_type_converters.cc View 1 2 3 4 3 chunks +106 lines, -182 lines 0 comments Download
A mojo/converters/blink/blink_input_events_type_converters_unittest.cc View 1 2 1 chunk +140 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Hadi
sky@, rjkroege@: PTAL at mojo/*. sievers@: PTAL at content/*. I wasn't sure if I should ...
4 years, 7 months ago (2016-05-05 15:25:44 UTC) #2
sky
LGTM
4 years, 7 months ago (2016-05-05 16:14:34 UTC) #3
Hadi
piman@ can you please review content/*? Thanks
4 years, 7 months ago (2016-05-09 13:16:02 UTC) #7
piman
lgtm
4 years, 7 months ago (2016-05-09 16:04:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949893003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949893003/120001
4 years, 7 months ago (2016-05-09 17:32:11 UTC) #11
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 7 months ago (2016-05-09 18:34:03 UTC) #13
commit-bot: I haz the power
4 years, 7 months ago (2016-05-09 18:36:09 UTC) #15
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/164cb9b90ff36afb164c3669973cadb71c92139f
Cr-Commit-Position: refs/heads/master@{#392376}

Powered by Google App Engine
This is Rietveld 408576698