Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1949883002: Disable GPU Raster for non-GPU-specific LayoutTests (Closed)

Created:
4 years, 7 months ago by ericrk
Modified:
4 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, jam, darin-cc_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable GPU Raster for non-GPU-specific LayoutTests With Gpu Raster landing on mac, layout tests may inadvertantly start being run with Gpu Raster enabled. This isn't desireable as it introduces variability into the layout tests depending on the Gpu. A small subset of LayoutTests specifically target GPU - in these cases we leave the previous behavior unchanged. BUG=542959 Committed: https://crrev.com/6929f4cf2946247bebde651d406e5d3fa2aedfbc Cr-Commit-Position: refs/heads/master@{#391609}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M content/shell/app/shell_main_delegate.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ericrk
4 years, 7 months ago (2016-05-04 00:19:38 UTC) #2
piman
LGTM, but do we have a GPU bot that runs all layout tests in gpu ...
4 years, 7 months ago (2016-05-04 00:44:20 UTC) #4
ericrk
On 2016/05/04 00:44:20, piman wrote: > LGTM, but do we have a GPU bot that ...
4 years, 7 months ago (2016-05-04 18:34:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949883002/1
4 years, 7 months ago (2016-05-04 18:35:24 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-04 20:03:52 UTC) #9
commit-bot: I haz the power
4 years, 7 months ago (2016-05-04 20:04:52 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6929f4cf2946247bebde651d406e5d3fa2aedfbc
Cr-Commit-Position: refs/heads/master@{#391609}

Powered by Google App Engine
This is Rietveld 408576698