src/js/array-iterator.js - Issue 1949863002: Fix TypedArray Property optimizations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/array-iterator.js

Issue 1949863002: Fix TypedArray Property optimizations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/js/array-iterator.js

diff --git a/src/js/array-iterator.js b/src/js/array-iterator.js

index b3e25e9adbe77b5d350921aadfe26572ed09e0a1..8203f1f9f5933e46727f4fab187c5e24665f2af2 100644

--- a/src/js/array-iterator.js

+++ b/src/js/array-iterator.js

@@ -22,7 +22,7 @@ var IteratorPrototype = utils.ImportNow("IteratorPrototype");

var iteratorSymbol = utils.ImportNow("iterator_symbol");

var MakeTypeError;

var toStringTagSymbol = utils.ImportNow("to_string_tag_symbol");

-var GlobalTypedArray = global.Uint8Array.__proto__;

+var GlobalTypedArray = %object_get_prototype_of(global.Uint8Array);

Dan Ehrenberg 2016/05/04 18:11:13 While this change is clearly valid, it would be ni

gsathya 2016/05/05 21:16:06 Not having this change doesn't break anything. I j

utils.Import(function(from) {

MakeTypeError = from.MakeTypeError;