Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: src/accessors.cc

Issue 1949863002: Fix TypedArray Property optimizations (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/bootstrapper.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/accessors.cc
diff --git a/src/accessors.cc b/src/accessors.cc
index ccae58255adecc2b6ae8037c0bccfc7ad5ece6bb..69f4e3e0dc4b0e95baaaaa656bbcd6ec11bba5c6 100644
--- a/src/accessors.cc
+++ b/src/accessors.cc
@@ -116,12 +116,12 @@ bool Accessors::IsJSArrayBufferViewFieldAccessor(Handle<Map> map,
LookupIterator it(proto, name);
if (!it.IsFound()) return false;
- Object* original_proto =
- JSFunction::cast(map->GetConstructor())->prototype();
+ HandleScope scope(isolate);
adamk 2016/05/04 18:44:36 You shouldn't need to create a HandleScope here, y
gsathya 2016/05/05 21:16:06 Done.
+ Handle<Object> typed_array_proto = isolate->typed_array_prototype();
// Property is not configurable. It is enough to verify that
// the holder is the same.
- return *it.GetHolder<Object>() == original_proto;
+ return *it.GetHolder<Object>() == *typed_array_proto;
}
case JS_DATA_VIEW_TYPE:
return CheckForName(name, isolate->factory()->byte_length_string(),
« no previous file with comments | « no previous file | src/bootstrapper.cc » ('j') | src/bootstrapper.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698