Revert of Compute snap offsets (both repeat and element based)

Revert of Compute snap offsets (both repeat and element based)  (patchset #31 id:600001 of https://codereview.chromium.org/1188563005/ )

Reason for revert:
Some snap tests are failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/46230

Original issue's description:
> Compute snap offsets according to CSS Scroll Snap Spec Level 1
>
> Add logic to compute snap offsets (those defined on snap container and snap
> areas) according to the published spec [1].
>
> SnapCoordinator maintains the mapping between snap containers and the snap
> areas. This mapping is stored in |LayoutBoxRareData| and updated on style
> change, attach, and detach events via hooks in |LayoutBox::styleWillChange| ,
> |LayoutBox::insertedIntoTree| and |LayoutBox::willBeDestoryed|.
>
> This implementation is the naive approach as described in [2]. It does not
> attempt to track which snap areas have moved in relation to their container to
> minimize  snap offsets re-computation. It simply re-computes all snap points
> every time they are needed.
>
> At the moment the computed snap offsets are not used for anything except to pass
> the tests. In future,  |SnapCoordinator| will compute them as part of the
> document lifecycle and send necessary updates to the Compositor Worker instance
> which is going to be responsible for snapping during scrolls.
>
> [1] https://www.w3.org/TR/2015/WD-css-snappoints-1-20150326/
> [2] https://docs.google.com/document/d/1BO0EgcMe3DTsO1uwM_psZeJ_Gz5OZR-oYrpJBKAJLoU/edit?pli=1
>
> Committed: https://crrev.com/3194544827727439d99dc72bec19d59a6004db0d
> Cr-Commit-Position: refs/heads/master@{#391562}

TBR=esprehn@chromium.org,eae@chromium.org,skobes@chromium.org,majidvp@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/daab7cf2092c7a61b6d03646ef1149075029d992
Cr-Commit-Position: refs/heads/master@{#391601}

[Mathieu, 2016-05-04 19:42:01]

Created Revert of Compute snap offsets (both repeat and element based)

[commit-bot: I haz the power, 2016-05-04 19:42:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949843004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949843004/1

[commit-bot: I haz the power, 2016-05-04 19:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:43:09]

Failed to apply patch for third_party/WebKit/Source/core/layout/LayoutBox.h:
While running git apply --index -3 -p1;
  error: patch failed: third_party/WebKit/Source/core/layout/LayoutBox.h:1087
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: third_party/WebKit/Source/core/layout/LayoutBox.h: patch does not apply

Patch:       third_party/WebKit/Source/core/layout/LayoutBox.h
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h
b/third_party/WebKit/Source/core/layout/LayoutBox.h
index
7e7e3c22d892c6bf398151048cbfd416b44c5bc6..05af5b173cdcc3bc18dd390ce1f7b5f51c4d1185
100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -57,8 +57,6 @@
     ApplyNonScrollOverflowClip
 };
 
-using SnapAreaSet = HashSet<const LayoutBox*>;
-
 struct LayoutBoxRareData {
     WTF_MAKE_NONCOPYABLE(LayoutBoxRareData);
USING_FAST_MALLOC(LayoutBoxRareData);
 public:
@@ -68,8 +66,6 @@
         , m_overrideLogicalContentWidth(-1)
         , m_previousBorderBoxSize(LayoutUnit(-1), LayoutUnit(-1))
         , m_percentHeightContainer(nullptr)
-        , m_snapContainer(nullptr)
-        , m_snapAreas(nullptr)
     {
     }
 
@@ -89,19 +85,6 @@
     LayoutUnit m_paginationStrut;
 
     LayoutBlock* m_percentHeightContainer;
-    // For snap area, the owning snap container.
-    LayoutBox* m_snapContainer;
-    // For snap container, the descendant snap areas that contribute snap
-    // points.
-    OwnPtr<SnapAreaSet> m_snapAreas;
-
-    SnapAreaSet& ensureSnapAreas()
-    {
-        if (!m_snapAreas)
-            m_snapAreas = adoptPtr(new SnapAreaSet);
-
-        return *m_snapAreas;
-    }
 };
 
 // LayoutBox implements the full CSS box model.
@@ -934,12 +917,6 @@
     void setPercentHeightContainer(LayoutBlock*);
     void removeFromPercentHeightContainer();
     void clearPercentHeightDescendants();
-    // For snap areas, returns the snap container that owns us.
-    LayoutBox* snapContainer() const;
-    void setSnapContainer(LayoutBox*);
-    // For snap containers, returns all associated snap areas.
-    SnapAreaSet* snapAreas() const;
-    void clearSnapAreas();
 
     bool hitTestClippedOutByRoundedBorder(const HitTestLocation&
locationInContainer, const LayoutPoint& borderBoxLocation) const;
 
@@ -1001,9 +978,6 @@
 
     void updateShapeOutsideInfoAfterStyleChange(const ComputedStyle&, const
ComputedStyle* oldStyle);
     void updateGridPositionAfterStyleChange(const ComputedStyle*);
-    void updateScrollSnapMappingAfterStyleChange(const ComputedStyle*, const
ComputedStyle* oldStyle);
-    void clearScrollSnapMapping();
-    void addScrollSnapMapping();
 
     bool autoWidthShouldFitContent() const;
     LayoutUnit shrinkToFitLogicalWidth(LayoutUnit availableLogicalWidth,
LayoutUnit bordersPlusPadding) const;
@@ -1087,9 +1061,6 @@
     void inflatePaintInvalidationRectForReflectionAndFilter(LayoutRect&) const;
 
     LayoutRectOutsets m_marginBoxOutsets;
-
-    void addSnapArea(const LayoutBox&);
-    void removeSnapArea(const LayoutBox&);
 
 protected:
     // The logical width of the element if it were to break its lines at every

[commit-bot: I haz the power, 2016-05-04 19:43:12]

The CQ bit was unchecked by commit-bot@chromium.org

[majidvp, 2016-05-04 19:56:16]

manual revert patch lgtm

[Mathieu, 2016-05-04 19:56:39]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2016-05-04 19:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949843004/220001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949843004/220001

[commit-bot: I haz the power, 2016-05-04 19:57:47]

Description was changed from

==========
Revert of Compute snap offsets (both repeat and element based)  (patchset #31
id:600001 of https://codereview.chromium.org/1188563005/ )

Reason for revert:
Some snap tests are failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

Original issue's description:
> Compute snap offsets according to CSS Scroll Snap Spec Level 1
> 
> Add logic to compute snap offsets (those defined on snap container and snap
> areas) according to the published spec [1].
> 
> SnapCoordinator maintains the mapping between snap containers and the snap
> areas. This mapping is stored in |LayoutBoxRareData| and updated on style
> change, attach, and detach events via hooks in |LayoutBox::styleWillChange| ,
> |LayoutBox::insertedIntoTree| and |LayoutBox::willBeDestoryed|.
> 
> This implementation is the naive approach as described in [2]. It does not
> attempt to track which snap areas have moved in relation to their container to
> minimize  snap offsets re-computation. It simply re-computes all snap points
> every time they are needed.
> 
> At the moment the computed snap offsets are not used for anything except to
pass
> the tests. In future,  |SnapCoordinator| will compute them as part of the
> document lifecycle and send necessary updates to the Compositor Worker
instance
> which is going to be responsible for snapping during scrolls.
> 
> [1] https://www.w3.org/TR/2015/WD-css-snappoints-1-20150326/
> [2]
https://docs.google.com/document/d/1BO0EgcMe3DTsO1uwM_psZeJ_Gz5OZR-oYrpJBKAJL...
> 
> Committed: https://crrev.com/3194544827727439d99dc72bec19d59a6004db0d
> Cr-Commit-Position: refs/heads/master@{#391562}

TBR=esprehn@chromium.org,eae@chromium.org,skobes@chromium.org,majidvp@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Compute snap offsets (both repeat and element based)  (patchset #31
id:600001 of https://codereview.chromium.org/1188563005/ )

Reason for revert:
Some snap tests are failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

Original issue's description:
> Compute snap offsets according to CSS Scroll Snap Spec Level 1
> 
> Add logic to compute snap offsets (those defined on snap container and snap
> areas) according to the published spec [1].
> 
> SnapCoordinator maintains the mapping between snap containers and the snap
> areas. This mapping is stored in |LayoutBoxRareData| and updated on style
> change, attach, and detach events via hooks in |LayoutBox::styleWillChange| ,
> |LayoutBox::insertedIntoTree| and |LayoutBox::willBeDestoryed|.
> 
> This implementation is the naive approach as described in [2]. It does not
> attempt to track which snap areas have moved in relation to their container to
> minimize  snap offsets re-computation. It simply re-computes all snap points
> every time they are needed.
> 
> At the moment the computed snap offsets are not used for anything except to
pass
> the tests. In future,  |SnapCoordinator| will compute them as part of the
> document lifecycle and send necessary updates to the Compositor Worker
instance
> which is going to be responsible for snapping during scrolls.
> 
> [1] https://www.w3.org/TR/2015/WD-css-snappoints-1-20150326/
> [2]
https://docs.google.com/document/d/1BO0EgcMe3DTsO1uwM_psZeJ_Gz5OZR-oYrpJBKAJL...
> 
> Committed: https://crrev.com/3194544827727439d99dc72bec19d59a6004db0d
> Cr-Commit-Position: refs/heads/master@{#391562}

TBR=esprehn@chromium.org,eae@chromium.org,skobes@chromium.org,majidvp@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

[commit-bot: I haz the power, 2016-05-04 19:57:48]

Committed patchset #2 (id:220001)

[commit-bot: I haz the power, 2016-05-04 19:59:16]

Description was changed from

==========
Revert of Compute snap offsets (both repeat and element based)  (patchset #31
id:600001 of https://codereview.chromium.org/1188563005/ )

Reason for revert:
Some snap tests are failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

Original issue's description:
> Compute snap offsets according to CSS Scroll Snap Spec Level 1
> 
> Add logic to compute snap offsets (those defined on snap container and snap
> areas) according to the published spec [1].
> 
> SnapCoordinator maintains the mapping between snap containers and the snap
> areas. This mapping is stored in |LayoutBoxRareData| and updated on style
> change, attach, and detach events via hooks in |LayoutBox::styleWillChange| ,
> |LayoutBox::insertedIntoTree| and |LayoutBox::willBeDestoryed|.
> 
> This implementation is the naive approach as described in [2]. It does not
> attempt to track which snap areas have moved in relation to their container to
> minimize  snap offsets re-computation. It simply re-computes all snap points
> every time they are needed.
> 
> At the moment the computed snap offsets are not used for anything except to
pass
> the tests. In future,  |SnapCoordinator| will compute them as part of the
> document lifecycle and send necessary updates to the Compositor Worker
instance
> which is going to be responsible for snapping during scrolls.
> 
> [1] https://www.w3.org/TR/2015/WD-css-snappoints-1-20150326/
> [2]
https://docs.google.com/document/d/1BO0EgcMe3DTsO1uwM_psZeJ_Gz5OZR-oYrpJBKAJL...
> 
> Committed: https://crrev.com/3194544827727439d99dc72bec19d59a6004db0d
> Cr-Commit-Position: refs/heads/master@{#391562}

TBR=esprehn@chromium.org,eae@chromium.org,skobes@chromium.org,majidvp@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
==========

to

==========
Revert of Compute snap offsets (both repeat and element based)  (patchset #31
id:600001 of https://codereview.chromium.org/1188563005/ )

Reason for revert:
Some snap tests are failing:

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28N...

Original issue's description:
> Compute snap offsets according to CSS Scroll Snap Spec Level 1
>
> Add logic to compute snap offsets (those defined on snap container and snap
> areas) according to the published spec [1].
>
> SnapCoordinator maintains the mapping between snap containers and the snap
> areas. This mapping is stored in |LayoutBoxRareData| and updated on style
> change, attach, and detach events via hooks in |LayoutBox::styleWillChange| ,
> |LayoutBox::insertedIntoTree| and |LayoutBox::willBeDestoryed|.
>
> This implementation is the naive approach as described in [2]. It does not
> attempt to track which snap areas have moved in relation to their container to
> minimize  snap offsets re-computation. It simply re-computes all snap points
> every time they are needed.
>
> At the moment the computed snap offsets are not used for anything except to
pass
> the tests. In future,  |SnapCoordinator| will compute them as part of the
> document lifecycle and send necessary updates to the Compositor Worker
instance
> which is going to be responsible for snapping during scrolls.
>
> [1] https://www.w3.org/TR/2015/WD-css-snappoints-1-20150326/
> [2]
https://docs.google.com/document/d/1BO0EgcMe3DTsO1uwM_psZeJ_Gz5OZR-oYrpJBKAJL...
>
> Committed: https://crrev.com/3194544827727439d99dc72bec19d59a6004db0d
> Cr-Commit-Position: refs/heads/master@{#391562}

TBR=esprehn@chromium.org,eae@chromium.org,skobes@chromium.org,majidvp@chromiu...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/daab7cf2092c7a61b6d03646ef1149075029d992
Cr-Commit-Position: refs/heads/master@{#391601}
==========

[commit-bot: I haz the power, 2016-05-04 19:59:18]

Patchset 2 (id:??) landed as
https://crrev.com/daab7cf2092c7a61b6d03646ef1149075029d992
Cr-Commit-Position: refs/heads/master@{#391601}