Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949833002: Fix a corner case of AST-based type inference with sequences of identifiers separated by '.'. (Closed)

Created:
4 years, 7 months ago by Paul Berry
Modified:
4 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a corner case of AST-based type inference with sequences of identifiers separated by '.'. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/db2e1df165dff586a21d3ba8850cd5877511af2a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -50 lines) Patch
M pkg/analyzer/lib/src/summary/link.dart View 6 chunks +47 lines, -50 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 chunk +36 lines, -0 lines 2 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
4 years, 7 months ago (2016-05-03 23:13:10 UTC) #2
scheglov
LGTM https://codereview.chromium.org/1949833002/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right): https://codereview.chromium.org/1949833002/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart#newcode2993 pkg/analyzer/test/src/task/strong/inferred_type_test.dart:2993: // level variable appears at the beginning of ...
4 years, 7 months ago (2016-05-03 23:35:16 UTC) #3
Paul Berry
https://codereview.chromium.org/1949833002/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart File pkg/analyzer/test/src/task/strong/inferred_type_test.dart (right): https://codereview.chromium.org/1949833002/diff/1/pkg/analyzer/test/src/task/strong/inferred_type_test.dart#newcode2993 pkg/analyzer/test/src/task/strong/inferred_type_test.dart:2993: // level variable appears at the beginning of a ...
4 years, 7 months ago (2016-05-04 01:45:28 UTC) #4
Paul Berry
4 years, 7 months ago (2016-05-04 01:48:39 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
db2e1df165dff586a21d3ba8850cd5877511af2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698