Issue 194983003: Disable gyptest-link-dependency.py for cmake, make it pass with ninja/win

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194983003: Disable gyptest-link-dependency.py for cmake, make it pass with ninja/win (Closed)

Created:
6 years, 9 months ago by Nico

Modified:
6 years, 9 months ago

Reviewers:
scottmg

CC:
gyp-developer_googlegroups.com, Alexander Potapenko

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

Disable gyptest-link-dependency.py for cmake, make it pass with ninja/win See https://codereview.chromium.org/177043010/#msg15 for the cmake bit, and the following comments for ninja/win. R=scottmg@chromium.org TBR=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1866

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	test/link-dependency/gyptest-link-dependency.py	View		1 chunk	+3 lines, -1 line	0 comments	Download
	M	test/link-dependency/mymalloc.c	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Nico

6 years, 9 months ago (2014-03-11 18:45:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r1866 (presubmit successful).