Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Unified Diff: components/mus/public/cpp/lib/window_tree_client_impl.cc

Issue 1949823002: WIP: Eliminate event.target() usage from TrayEventFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: container delegate Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/mus/demo/mus_demo.cc ('k') | components/mus/public/cpp/tests/window_server_test_base.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/mus/public/cpp/lib/window_tree_client_impl.cc
diff --git a/components/mus/public/cpp/lib/window_tree_client_impl.cc b/components/mus/public/cpp/lib/window_tree_client_impl.cc
index 5c5f5a3febef544dbbff08cca954f80f7ac308b6..36c5ba74441e32cf03cfc55268141b48e8e53021 100644
--- a/components/mus/public/cpp/lib/window_tree_client_impl.cc
+++ b/components/mus/public/cpp/lib/window_tree_client_impl.cc
@@ -911,14 +911,14 @@ void WindowTreeClientImpl::OnWindowInputEvent(uint32_t event_id,
mojom::EventPtr event,
uint32_t event_observer_id) {
std::unique_ptr<ui::Event> ui_event = event.To<std::unique_ptr<ui::Event>>();
+ Window* window = GetWindowByServerId(window_id); // May be null.
// Non-zero event_observer_id means it matched an event observer on the
// server.
if (event_observer_id != 0 && has_event_observer_ &&
event_observer_id == event_observer_id_)
- delegate_->OnEventObserved(*ui_event);
+ delegate_->OnEventObserved(*ui_event, window);
- Window* window = GetWindowByServerId(window_id);
if (!window || !window->input_event_handler_) {
tree_->OnWindowInputEventAck(event_id, mojom::EventResult::UNHANDLED);
return;
@@ -942,7 +942,7 @@ void WindowTreeClientImpl::OnEventObserved(mojom::EventPtr event,
if (has_event_observer_ && event_observer_id == event_observer_id_) {
std::unique_ptr<ui::Event> ui_event =
event.To<std::unique_ptr<ui::Event>>();
- delegate_->OnEventObserved(*ui_event);
+ delegate_->OnEventObserved(*ui_event, nullptr /* target */);
}
}
« no previous file with comments | « components/mus/demo/mus_demo.cc ('k') | components/mus/public/cpp/tests/window_server_test_base.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698