Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: cc/output/output_surface.cc

Issue 1949753007: Detach the output surface if bind fails. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/output/output_surface.cc
diff --git a/cc/output/output_surface.cc b/cc/output/output_surface.cc
index 30864f1ff548e45b767f22b9ace117173015a7a9..08bb4d21b150244df9cca60bc2b8012f269880f4 100644
--- a/cc/output/output_surface.cc
+++ b/cc/output/output_surface.cc
@@ -214,7 +214,7 @@ bool OutputSurface::BindToClient(OutputSurfaceClient* client) {
}
if (!success)
- client_ = NULL;
+ DetachFromClient();
piman 2016/05/06 19:41:40 this will do the MemoryDumpManager::GetInstance()-
danakj 2016/05/06 20:19:56 Argh OutputSurface. There are a lot of bad options
// In certain cases, ThreadTaskRunnerHandle isn't set (Android Webview).
// Don't register a dump provider in these cases.
« no previous file with comments | « no previous file | content/renderer/gpu/compositor_output_surface.cc » ('j') | content/renderer/gpu/compositor_output_surface.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698