Revert of chromeos: Turn off displays on suspend

Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume from suspend.

Perhaps "the delay for restoring the display state" really is important after all.

BUG=chrome-os-partner:52916
Original issue's description:
> chromeos: Turn off displays on suspend
>
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
>
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
>
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromium.org,tbroch@chromium.org,ejcaruso@chromium.org,dnicoara@chromium.org,marcheu@google.com,spang@chromium.org,dbasehore@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
Committed: https://crrev.com/a3145f9cee03fd27c8c04511e95b8217f489889c
Cr-Commit-Position: refs/heads/master@{#392006}

[Daniel Kurtz, 2016-05-05 10:44:58]

Created Revert of chromeos: Turn off displays on suspend

[commit-bot: I haz the power, 2016-05-05 10:45:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949753004/1

[commit-bot: I haz the power, 2016-05-05 10:45:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-05 10:45:18]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Daniel Kurtz, 2016-05-05 10:45:28]

Description was changed from

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.  Next time, I recommend including just one logical change per patch.

BUG=chrome-os-partner:52916



Original issue's description:
> chromeos: Turn off displays on suspend
> 
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
> 
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
> 
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
==========

to

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.

BUG=chrome-os-partner:52916



Original issue's description:
> chromeos: Turn off displays on suspend
> 
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
> 
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
> 
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
==========

[Daniel Erat, 2016-05-05 13:54:46]

lgtm

[Daniel Kurtz, 2016-05-06 00:40:21]

The CQ bit was checked by djkurtz@chromium.org

[commit-bot: I haz the power, 2016-05-06 00:40:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949753004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949753004/1

[commit-bot: I haz the power, 2016-05-06 00:43:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-06 00:43:40]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios-device on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Daniel Kurtz, 2016-05-06 04:30:14]

On 2016/05/06 00:43:40, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
>   ios-device on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
>   ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
>   ios-simulator on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
>   ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
>   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Oh, the patch that actually landed is [0], which was patch set #11 of [1], not
the final 
[0]
https://chromium.googlesource.com/chromium/src/+/fee6ba82e703d68c296730aa38ea...
[1] https://codereview.chromium.org/1861593002

Patch set #11 only changes the following three files:

ui/display/chromeos/display_configurator.cc
ui/display/chromeos/display_configurator.h
ui/display/chromeos/display_configurator_unittest.cc

However, in Rietveld, there is a patch set #12, which is what this patch tries
to revert.
I'm not sure how that happened.

[Daniel Kurtz, 2016-05-06 04:41:49]

The CQ bit was checked by djkurtz@chromium.org

[Daniel Kurtz, 2016-05-06 04:41:49]

The patchset sent to the CQ was uploaded after l-g-t-m from derat@chromium.org
Link to the patchset: https://codereview.chromium.org/1949753004/#ps250001
(title: "Revert PS that actually landed: PS#11, not PS#12")

[commit-bot: I haz the power, 2016-05-06 04:41:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949753004/250001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949753004/250001

[oshima, 2016-05-06 04:44:27]

On 2016/05/06 04:30:14, Daniel Kurtz wrote:
> On 2016/05/06 00:43:40, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
> (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
> >   ios-device on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
> >   ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
> >   ios-simulator on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
> >   ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
> >   mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
> >   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
> 
> Oh, the patch that actually landed is [0], which was patch set #11 of [1], not
> the final 
> [0]
>
https://chromium.googlesource.com/chromium/src/+/fee6ba82e703d68c296730aa38ea...
> [1] https://codereview.chromium.org/1861593002
> 
> Patch set #11 only changes the following three files:
> 
> ui/display/chromeos/display_configurator.cc
> ui/display/chromeos/display_configurator.h
> ui/display/chromeos/display_configurator_unittest.cc
> 
> However, in Rietveld, there is a patch set #12, which is what this patch tries
> to revert.
> I'm not sure how that happened.

I guess dbasehore@ have uploaded another patch on top of the CL that has already
committed,
and rietveld tried to revert that patch, instead of the patch that has landed.

It's probably a bug in Rietveld.

[commit-bot: I haz the power, 2016-05-06 05:24:54]

Description was changed from

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.

BUG=chrome-os-partner:52916



Original issue's description:
> chromeos: Turn off displays on suspend
> 
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
> 
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
> 
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
==========

to

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.

BUG=chrome-os-partner:52916



Original issue's description:
> chromeos: Turn off displays on suspend
> 
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
> 
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
> 
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
==========

[commit-bot: I haz the power, 2016-05-06 05:24:55]

Committed patchset #2 (id:250001)

[commit-bot: I haz the power, 2016-05-06 05:26:34]

Description was changed from

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.

BUG=chrome-os-partner:52916



Original issue's description:
> chromeos: Turn off displays on suspend
> 
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
> 
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
> 
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021
==========

to

==========
Revert of chromeos: Turn off displays on suspend (patchset #12 id:220001 of
https://codereview.chromium.org/1861593002/ )

Reason for revert:
With this patch, the internal display (on oak, at least) stays black on resume
from suspend.

Perhaps "the delay for restoring the display state" really is important after
all.

BUG=chrome-os-partner:52916

Original issue's description:
> chromeos: Turn off displays on suspend
>
> To handle lucid sleep (where we need to silently resume the system), turn
> off the displays on suspend. This also removes the delay for restoring the
> display state added in "On resume perform a delayed call to
> SetDisplayPower()" According to the bug for that change, it didn't seem to
> help with the issue anyways.
>
> BUG=535021
> TEST=suspend/resume of various cros platforms with/without external monitor
> connected
>
> Committed: https://crrev.com/fee6ba82e703d68c296730aa38ea1d4f77854631
> Cr-Commit-Position: refs/heads/master@{#389875}

TBR=derat@chromium.org,oshima@chromium.org,marcheu@chromium.org,snanda@chromi...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=535021

Committed: https://crrev.com/a3145f9cee03fd27c8c04511e95b8217f489889c
Cr-Commit-Position: refs/heads/master@{#392006}
==========

[commit-bot: I haz the power, 2016-05-06 05:26:36]

Patchset 2 (id:??) landed as
https://crrev.com/a3145f9cee03fd27c8c04511e95b8217f489889c
Cr-Commit-Position: refs/heads/master@{#392006}

[dbasehore, 2016-05-06 20:22:04]

A revert of this CL (patchset #2 id:250001) has been created in
https://codereview.chromium.org/1955103002/ by dbasehore@chromium.org.

The reason for reverting is: The issue is fixed in the kernel. It was a problem
with suspend/resume and the display encoder for a platform that is fixed in
https://chromium-review.googlesource.com/#/c/342845/.