Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1949733002: fix #543, export of properties should now work (Closed)

Created:
4 years, 7 months ago by Jennifer Messerly
Modified:
4 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fix #543, export of properties should now work top-level fields, getters, setters were all broken R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/698e84ab5fe24e02299029e46f6d4aa0e7d16ed5

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -138 lines) Patch
M lib/runtime/dart_sdk.js View 1 3 chunks +32 lines, -18 lines 0 comments Download
M lib/src/compiler/code_generator.dart View 1 3 chunks +27 lines, -2 lines 0 comments Download
M test/codegen/expect/unittest.js View 1 1 chunk +29 lines, -29 lines 0 comments Download
M test/codegen/expect/unittest/unittest.js View 1 1 chunk +29 lines, -29 lines 0 comments Download
A + test/codegen/language/export_order_helper1.dart View 1 chunk +1 line, -6 lines 0 comments Download
A + test/codegen/language/export_order_helper2.dart View 1 chunk +3 lines, -4 lines 0 comments Download
A + test/codegen/language/export_order_test.dart View 1 chunk +7 lines, -9 lines 0 comments Download
M tool/input_sdk/private/ddc_runtime/utils.dart View 1 3 chunks +52 lines, -41 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Jennifer Messerly
4 years, 7 months ago (2016-05-03 21:02:21 UTC) #3
vsm
lgtm https://codereview.chromium.org/1949733002/diff/20001/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/1949733002/diff/20001/lib/src/compiler/code_generator.dart#newcode403 lib/src/compiler/code_generator.dart:403: _moduleItems.add(js.statement('dart.copyProperty(#, #, #);', From a readability standpoint, perhaps ...
4 years, 7 months ago (2016-05-03 21:59:14 UTC) #6
Jennifer Messerly
Thanks! https://codereview.chromium.org/1949733002/diff/20001/lib/src/compiler/code_generator.dart File lib/src/compiler/code_generator.dart (right): https://codereview.chromium.org/1949733002/diff/20001/lib/src/compiler/code_generator.dart#newcode403 lib/src/compiler/code_generator.dart:403: _moduleItems.add(js.statement('dart.copyProperty(#, #, #);', On 2016/05/03 21:59:14, vsm wrote: ...
4 years, 7 months ago (2016-05-03 23:37:28 UTC) #7
Jennifer Messerly
4 years, 7 months ago (2016-05-03 23:37:47 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
698e84ab5fe24e02299029e46f6d4aa0e7d16ed5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698