Issue 194973003: Alter bench_pictures to "respect" the logPerIter flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 194973003: Alter bench_pictures to "respect" the logPerIter flag (Closed)

Created:
6 years, 9 months ago by robertphillips

Modified:
6 years, 9 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Alter bench_pictures to "respect" the logPerIter flag. When --logPerIters is set and --repeat is great then 2 then bench_pictures will run each test "repeat" times (to generate the correct number of timings) by rendering 5 times. This CL also adds a swapBuffers in addition to the pre-existing flush calls. Committed: http://code.google.com/p/skia/source/detail?r=13752

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -51 lines)			Patch
M	debugger/QT/SkDebuggerGUI.cpp	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/PictureBenchmark.cpp	View	6 chunks	+67 lines, -48 lines	0 comments	Download
M	tools/PictureRenderer.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/PictureRenderer.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

The CQ bit was checked by robertphillips@google.com

6 years, 9 months ago (2014-03-11 19:59:20 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/robertphillips@google.com/194973003/1

6 years, 9 months ago (2014-03-11 19:59:29 UTC) #4

Message was sent while issue was closed.

Change committed as 13752

Expand Messages | Collapse Messages