Issue 1949713004: Only call .hasResolvedAst in assertions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1949713004: Only call .hasResolvedAst in assertions. (Closed)

Created:
4 years, 7 months ago by Johnni Winther

Modified:
4 years, 7 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -8 lines)			Patch
	M	pkg/compiler/lib/src/compiler.dart	View		1 chunk	+4 lines, -7 lines	0 comments	Download
	M	pkg/compiler/lib/src/parser/listener.dart	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (2 generated)

sra1

LGTM. This seems to have a mild positive effect on performance (+0.4%)

4 years, 7 months ago (2016-05-05 18:38:13 UTC) #3

Johnni Winther

4 years, 7 months ago (2016-05-09 08:34:10 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6e491cf15250eba3478c809d278fa4fde62e9d43 (presubmit successful).