Sampling heap profiler: Force Full GC before retrieving the profile.

Sampling heap profiler: Force Full GC before retrieving the profile.

BUG=v8:4959
LOG=N

Committed: https://crrev.com/0a8cd4dc02ee1237f3c65ec20ecbc26c1bbda76e
Cr-Commit-Position: refs/heads/master@{#36042}

[alph, 2016-05-03 23:36:40]

alph@chromium.org changed reviewers:
+ hpayer@chromium.org, ofrobots@google.com, ulan@chromium.org

[ulan, 2016-05-04 09:34:51]

I posted an alternative solution in
https://bugs.chromium.org/p/v8/issues/detail?id=4959

Let's check if that helps before forcing GCs.

[ulan, 2016-05-04 13:13:06]

Ali explained us that DevTools needs precise allocation profile, so this LGTM.

https://codereview.chromium.org/1949693003/diff/20001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/1949693003/diff/20001/include/v8-profiler.h#n...
include/v8-profiler.h:520: kSamplingForceGC = 1 << 0,
To be more descriptive, maybe kSamplingForceGCAtAllocationProfile or something
similar?

[alph, 2016-05-04 18:40:16]

https://codereview.chromium.org/1949693003/diff/20001/include/v8-profiler.h
File include/v8-profiler.h (right):

https://codereview.chromium.org/1949693003/diff/20001/include/v8-profiler.h#n...
include/v8-profiler.h:520: kSamplingForceGC = 1 << 0,
On 2016/05/04 13:13:06, ulan wrote:
> To be more descriptive, maybe kSamplingForceGCAtAllocationProfile or something
> similar?

Don't think we should go into implementation details here.

[alph, 2016-05-04 18:40:22]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-05-04 18:40:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1949693003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1949693003/20001

[commit-bot: I haz the power, 2016-05-04 19:16:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-05-04 19:16:36]

Description was changed from

==========
Sampling heap profiler: Force Full GC before retrieving the profile.

BUG=v8:4959
LOG=N
==========

to

==========
Sampling heap profiler: Force Full GC before retrieving the profile.

BUG=v8:4959
LOG=N

Committed: https://crrev.com/0a8cd4dc02ee1237f3c65ec20ecbc26c1bbda76e
Cr-Commit-Position: refs/heads/master@{#36042}
==========

[commit-bot: I haz the power, 2016-05-04 19:16:38]

Patchset 2 (id:??) landed as
https://crrev.com/0a8cd4dc02ee1237f3c65ec20ecbc26c1bbda76e
Cr-Commit-Position: refs/heads/master@{#36042}