Implement 'assignToRef' resynthesizing.

Implement 'assignToRef' resynthesizing.

The failing tests partially depend on your CL for adding all static
class members, although probably will require some more changes.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/e79a2b1774e0f744a8006c37c628c5c5611eb660

[scheglov, 2016-05-03 19:28:18]

PTAL

[Paul Berry, 2016-05-03 19:33:41]

lgtm assuming you like my suggestion below.

https://codereview.chromium.org/1949693002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1949693002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/resynthesize.dart:462:
_push(AstFactory.identifier3(r'$notConst$'));
This seems dangerous to me, since it breaks the tracking of intPtr.  Which means
that later in the loop, we might get garbage data in our intPtr, leading to a
crash.

Since it just takes one invalid operation to render the entire constant
expression invalid, how about if we just do this instead?

return AstFactory.identifier3(r'$notConst$');

[scheglov, 2016-05-03 20:02:44]

https://codereview.chromium.org/1949693002/diff/20001/pkg/analyzer/lib/src/su...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1949693002/diff/20001/pkg/analyzer/lib/src/su...
pkg/analyzer/lib/src/summary/resynthesize.dart:462:
_push(AstFactory.identifier3(r'$notConst$'));
On 2016/05/03 19:33:41, Paul Berry wrote:
> This seems dangerous to me, since it breaks the tracking of intPtr.  Which
means
> that later in the loop, we might get garbage data in our intPtr, leading to a
> crash.
> 
> Since it just takes one invalid operation to render the entire constant
> expression invalid, how about if we just do this instead?
> 
> return AstFactory.identifier3(r'$notConst$');

Done.

[scheglov, 2016-05-03 20:03:00]

Description was changed from

==========
Implement 'assignToRef' resynthesizing.

The failing tests partially depend on your CL for adding all static
class members, although probably will require some more changes.

R=paulberry@google.com
BUG=
==========

to

==========
Implement 'assignToRef' resynthesizing.

The failing tests partially depend on your CL for adding all static
class members, although probably will require some more changes.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/e79a2b1774e0f744a8006c37c628c5c5611eb660
==========

[scheglov, 2016-05-03 20:03:02]

Committed patchset #2 (id:20001) manually as
e79a2b1774e0f744a8006c37c628c5c5611eb660 (presubmit successful).