Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Unified Diff: client/utils/logging_utils.py

Issue 1949613002: task_runner: always use run_isolated (Closed) Base URL: https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Patch Set: Fix task_runner.py Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/utils/logging_utils.py
diff --git a/client/utils/logging_utils.py b/client/utils/logging_utils.py
index c908233ba3d3bcd836c8035878ec0a8da64f0083..ef09c19a44c8b9738144092b43fcf16ed0b2c997 100644
--- a/client/utils/logging_utils.py
+++ b/client/utils/logging_utils.py
@@ -15,6 +15,7 @@ import sys
import tempfile
import time
+import file_path
# This works around file locking issue on Windows specifically in the case of
# long lived child processes.
@@ -199,6 +200,7 @@ def prepare_logging(filename, root=None):
# Setup up logging to a constant file so we can debug issues where
# the results aren't properly sent to the result URL.
if filename:
+ file_path.ensure_tree(os.path.dirname(os.path.abspath(unicode(filename))))
try:
rotating_file = NoInheritRotatingFileHandler(
filename, maxBytes=10 * 1024 * 1024, backupCount=5,
« appengine/swarming/swarming_bot/bot_code/task_runner_test.py ('K') | « client/run_isolated.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698