|
|
Descriptiontask_runner: always use run_isolated
run_isolated learned to run non-isolated commands. Use it for ordinary
commands in task_runner.
R=maruel@chromium.org
BUG=601022
Committed: https://github.com/luci/luci-py/commit/5c6162e91858e17f4cfcedb50438d2e2baf5ec12
Patch Set 1 #Patch Set 2 : remove hard timeout #Patch Set 3 : Fix task_runner.py #
Total comments: 2
Patch Set 4 : fix tests #Patch Set 5 : rebased #Patch Set 6 : fix lint errors #Patch Set 7 : rebased and ignored bot_overhead #Patch Set 8 : rebased #
Messages
Total messages: 59 (31 generated)
PTAL
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/1
Perhaps this code must be updated with isolate.py in the same CL?
On 2016/05/03 17:24:43, nodir wrote: > Perhaps this code must be updated with isolate.py in the same CL? isolate.py? The CL itself lgtm. Deploying to chros prox will require more careful deployment.
On 2016/05/03 17:48:57, M-A Ruel wrote: > On 2016/05/03 17:24:43, nodir wrote: > > Perhaps this code must be updated with isolate.py in the same CL? > > isolate.py? Sorry, I meant CMDreproduce in swarming.py
I've removed hard timeout too, ptal
ping
lgtm
The CQ bit was checked by nodir@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui...)
Patchset #3 (id:40001) has been deleted
Patchset #3 (id:60001) has been deleted
Patchset #3 (id:80001) has been deleted
PTAL again. This change is not that easy https://codereview.chromium.org/1949613002/diff/100001/appengine/swarming/swa... File appengine/swarming/swarming_bot/bot_code/task_runner_test.py (left): https://codereview.chromium.org/1949613002/diff/100001/appengine/swarming/swa... appengine/swarming/swarming_bot/bot_code/task_runner_test.py:370: self.assertEqual(task_details.command, cmd) this test is not about checking command anyway https://codereview.chromium.org/1949613002/diff/100001/appengine/swarming/swa... appengine/swarming/swarming_bot/bot_code/task_runner_test.py:1041: expected = { wasn't used
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui...)
lgtm
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/140001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui...)
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui...)
Patchset #7 (id:180001) has been deleted
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/220001
Patchset #7 (id:200001) has been deleted
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Patchset #7 (id:220001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1949613002/#ps260001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/260001
The CQ bit was unchecked by nodir@chromium.org
Patchset #8 (id:260001) has been deleted
Patchset #7 (id:240001) has been deleted
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1949613002/#ps280001 (title: "rebased and ignored bot_overhead")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/280001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/bui...)
The CQ bit was checked by nodir@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/300001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nodir@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from maruel@chromium.org Link to the patchset: https://codereview.chromium.org/1949613002/#ps300001 (title: "rebased")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/300001
Message was sent while issue was closed.
Description was changed from ========== task_runner: always use run_isolated run_isolated learned to run non-isolated commands. Use it for ordinary commands in task_runner. R=maruel@chromium.org BUG=601022 ========== to ========== task_runner: always use run_isolated run_isolated learned to run non-isolated commands. Use it for ordinary commands in task_runner. R=maruel@chromium.org BUG=601022 Committed: https://github.com/luci/luci-py/commit/5c6162e91858e17f4cfcedb50438d2e2baf5ec12 ==========
Message was sent while issue was closed.
Committed patchset #8 (id:300001) as https://github.com/luci/luci-py/commit/5c6162e91858e17f4cfcedb50438d2e2baf5ec12 |