Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 1949613002: task_runner: always use run_isolated (Closed)

Created:
4 years, 7 months ago by nodir
Modified:
4 years, 6 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, infra-reviews+luci-py_chromium.org
Base URL:
https://chromium.googlesource.com/external/github.com/luci/luci-py@master
Target Ref:
refs/heads/master
Project:
luci-py
Visibility:
Public.

Description

task_runner: always use run_isolated run_isolated learned to run non-isolated commands. Use it for ordinary commands in task_runner. R=maruel@chromium.org BUG=601022 Committed: https://github.com/luci/luci-py/commit/5c6162e91858e17f4cfcedb50438d2e2baf5ec12

Patch Set 1 #

Patch Set 2 : remove hard timeout #

Patch Set 3 : Fix task_runner.py #

Total comments: 2

Patch Set 4 : fix tests #

Patch Set 5 : rebased #

Patch Set 6 : fix lint errors #

Patch Set 7 : rebased and ignored bot_overhead #

Patch Set 8 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+131 lines, -130 lines) Patch
M appengine/swarming/local_smoke_test.py View 1 2 3 4 5 6 7 5 chunks +14 lines, -8 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/task_runner.py View 1 2 3 4 5 6 7 7 chunks +73 lines, -83 lines 0 comments Download
M appengine/swarming/swarming_bot/bot_code/task_runner_test.py View 1 2 3 4 5 6 7 13 chunks +35 lines, -35 lines 0 comments Download
M client/run_isolated.py View 1 2 3 4 5 6 7 3 chunks +7 lines, -4 lines 0 comments Download
M client/utils/logging_utils.py View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 59 (31 generated)
nodir
PTAL
4 years, 7 months ago (2016-05-03 17:24:12 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/1
4 years, 7 months ago (2016-05-03 17:24:27 UTC) #3
nodir
Perhaps this code must be updated with isolate.py in the same CL?
4 years, 7 months ago (2016-05-03 17:24:43 UTC) #4
M-A Ruel
On 2016/05/03 17:24:43, nodir wrote: > Perhaps this code must be updated with isolate.py in ...
4 years, 7 months ago (2016-05-03 17:48:57 UTC) #5
nodir
On 2016/05/03 17:48:57, M-A Ruel wrote: > On 2016/05/03 17:24:43, nodir wrote: > > Perhaps ...
4 years, 7 months ago (2016-05-03 17:54:16 UTC) #6
nodir
I've removed hard timeout too, ptal
4 years, 7 months ago (2016-05-03 17:54:56 UTC) #7
nodir
ping
4 years, 7 months ago (2016-05-09 22:51:06 UTC) #8
M-A Ruel
lgtm
4 years, 7 months ago (2016-05-10 14:17:16 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/20001
4 years, 7 months ago (2016-05-11 16:15:58 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/802)
4 years, 7 months ago (2016-05-11 17:39:52 UTC) #13
nodir
PTAL again. This change is not that easy https://codereview.chromium.org/1949613002/diff/100001/appengine/swarming/swarming_bot/bot_code/task_runner_test.py File appengine/swarming/swarming_bot/bot_code/task_runner_test.py (left): https://codereview.chromium.org/1949613002/diff/100001/appengine/swarming/swarming_bot/bot_code/task_runner_test.py#oldcode370 appengine/swarming/swarming_bot/bot_code/task_runner_test.py:370: self.assertEqual(task_details.command, ...
4 years, 7 months ago (2016-05-12 21:46:23 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/100001
4 years, 7 months ago (2016-05-12 21:52:18 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/810)
4 years, 7 months ago (2016-05-12 21:59:09 UTC) #21
M-A Ruel
lgtm
4 years, 7 months ago (2016-05-13 00:09:28 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/140001
4 years, 7 months ago (2016-05-25 00:25:02 UTC) #24
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/848)
4 years, 7 months ago (2016-05-25 00:30:33 UTC) #26
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/160001
4 years, 6 months ago (2016-05-27 17:05:06 UTC) #28
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/865)
4 years, 6 months ago (2016-05-27 17:14:34 UTC) #30
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/220001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/220001
4 years, 6 months ago (2016-05-27 18:44:26 UTC) #33
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/240001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/240001
4 years, 6 months ago (2016-05-27 18:47:46 UTC) #37
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 18:54:16 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/260001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/260001
4 years, 6 months ago (2016-05-27 20:28:38 UTC) #42
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/280001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/280001
4 years, 6 months ago (2016-05-27 20:31:45 UTC) #48
commit-bot: I haz the power
Try jobs failed on following builders: Luci-py Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Luci-py%20Presubmit/builds/875)
4 years, 6 months ago (2016-05-27 20:33:55 UTC) #50
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/300001
4 years, 6 months ago (2016-05-27 20:50:14 UTC) #52
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-05-27 20:53:05 UTC) #54
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1949613002/300001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1949613002/300001
4 years, 6 months ago (2016-05-27 20:53:33 UTC) #57
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 20:59:11 UTC) #59
Message was sent while issue was closed.
Committed patchset #8 (id:300001) as
https://github.com/luci/luci-py/commit/5c6162e91858e17f4cfcedb50438d2e2baf5ec12

Powered by Google App Engine
This is Rietveld 408576698